Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out Azure Firewall, Gitea and Nexus from core TRE components #1177

Closed
3 tasks
tanya-borisova opened this issue Jan 26, 2022 · 3 comments · Fixed by #1365
Closed
3 tasks

Split out Azure Firewall, Gitea and Nexus from core TRE components #1177

tanya-borisova opened this issue Jan 26, 2022 · 3 comments · Fixed by #1365
Assignees
Labels
story Stories are the smallest unit of work to be done for a project.
Milestone

Comments

@tanya-borisova
Copy link
Contributor

tanya-borisova commented Jan 26, 2022

Description

As a customer of Azure TRE
I want to opt-in into having {Azure Firewall, Gitea, Nexus} deployed
So that I can decide whether it meets my needs

Acceptance criteria

  • Firewall deployment is decoupled from the deployment of the core TRE components
  • Gitea deployment is decoupled from the deployment of the core TRE components
  • Nexus deployment is decoupled from the deployment of the core TRE components

Notes

This is related (and likely part of) issue #23
This is also related to resolving bug #1165 (as implementing this will likely make the bug go away)

@tanya-borisova tanya-borisova added the story Stories are the smallest unit of work to be done for a project. label Jan 26, 2022
@tanya-borisova tanya-borisova self-assigned this Jan 26, 2022
@daltskin daltskin moved this to Triage in AzureTRE - Crew Rock Jan 27, 2022
@daltskin daltskin moved this from Triage to In Progress in AzureTRE - Crew Rock Jan 27, 2022
@marrobi marrobi added this to the Release 0.3 milestone Jan 27, 2022
@tanya-borisova
Copy link
Contributor Author

It turns out that Azure Firewall currently can't be destroyed from Terraform (but can from Portal).
Link to the issue in the azurerm Terraform provider: hashicorp/terraform-provider-azurerm#14866

To deploy this change, we would have to ask everybody to manually delete Firewall in their dev deployment, as well as delete it manually for the CI deployment.

@tanya-borisova
Copy link
Contributor Author

It also turns out that Gitea and Nexus won't work as part of core terraform if Firewall is extracted into the shared service, so all 3 components are extracted into Porter bundles as part of this ticket

@daltskin daltskin moved this from In Progress to PR in AzureTRE - Crew Rock Feb 2, 2022
@tanya-borisova tanya-borisova linked a pull request Feb 4, 2022 that will close this issue
4 tasks
@tanya-borisova tanya-borisova changed the title Split out Azure Firewall deployment from core TRE components Split out Azure Firewall, Gitea and Nexus from core TRE components Feb 4, 2022
@tanya-borisova
Copy link
Contributor Author

tanya-borisova commented Feb 4, 2022

Talked to @marrobi today and we agreed that in order to minimise disruption to existing users of TRE, I will attempt to run terraform state rm for the resources in core terraform, followed by terraform import in the Porter bundles terraform states.
This is to ensure continuity of existing deployments of Firewall, Gitea and Nexus, as terraform won't destroy and create them again.

@damoodamoo damoodamoo linked a pull request Feb 22, 2022 that will close this issue
Repository owner moved this from PR to Done in AzureTRE - Crew Rock Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
story Stories are the smallest unit of work to be done for a project.
Projects
No open projects
Status: Done
3 participants