Gitea, Nexus: Move variable inputs to data and locals #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ross-p-smith
approved these changes
Feb 1, 2022
ross-p-smith
reviewed
Feb 1, 2022
|
@ross-p-smith how do I trigger them now? I used to be able to set "safe to test" tag but I don't think it does anything anymore |
… github.com:tanya-borisova/AzureTRE into tborisova/move-variables-to-data-prepare-for-porter
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #1177
NOTE: this PR is base for tanya-borisova#1
What is being addressed
In order to prepare extraction of Gitea and Nexus to Porter bundles,
variableinputs need to be changed todatainputs, to simplify configuration of the Porter bundles.How is this addressed
locals(e.g.firewall_name,storage_name, etc). I considered passing them as env variables first, but our env configuration is already fairly complicated. Happy to discuss this point though.