Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug and Purge Protection Core and Workspace #1201

Closed
mike-westaway opened this issue Jan 28, 2022 · 1 comment · Fixed by #1701 or #1714
Closed

Debug and Purge Protection Core and Workspace #1201

mike-westaway opened this issue Jan 28, 2022 · 1 comment · Fixed by #1701 or #1714
Assignees
Labels
bug Something isn't working

Comments

@mike-westaway
Copy link

Remember to label the issue with the appropriate area, and also assign it to yourself if you plan to work on the issue in the near future.

Describe the bug
Setting debug to true disables Purge Protection in the core
https://microsoft.github.io/AzureTRE/tre-admins/environment-variables/#for-shared-management-resources-in-devopsenv

Workspace are still created with Purge Protection enabled (and it cannot be disbaled)

Suggest that debug should consistently set Purge Protection for both core and workspace

This could be done by replicating the setting in
https://github.com/microsoft/AzureTRE/blob/main/templates/core/terraform/keyvault/keyvault.tf
to
https://github.com/microsoft/AzureTRE/blob/main/templates/workspaces/base/terraform/keyvault.tf

Steps to reproduce

  1. Follow setup instructions https://microsoft.github.io/AzureTRE/tre-admins/setup-instructions/getting-started/
  2. In Step 2 set Debug="false"
  3. Create Workspace, observe that in the core KeyVault Purge protection is disabled and in the Workspace KeyVault purge protection is enabled
@mike-westaway mike-westaway added the bug Something isn't working label Jan 28, 2022
@marrobi
Copy link
Member

marrobi commented Jan 28, 2022

Linked to #1163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
4 participants