We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remember to label the issue with the appropriate area, and also assign it to yourself if you plan to work on the issue in the near future.
Describe the bug Setting debug to true disables Purge Protection in the core https://microsoft.github.io/AzureTRE/tre-admins/environment-variables/#for-shared-management-resources-in-devopsenv
Workspace are still created with Purge Protection enabled (and it cannot be disbaled)
Suggest that debug should consistently set Purge Protection for both core and workspace
This could be done by replicating the setting in https://github.com/microsoft/AzureTRE/blob/main/templates/core/terraform/keyvault/keyvault.tf to https://github.com/microsoft/AzureTRE/blob/main/templates/workspaces/base/terraform/keyvault.tf
Steps to reproduce
The text was updated successfully, but these errors were encountered:
Linked to #1163
Sorry, something went wrong.
ross-p-smith
Successfully merging a pull request may close this issue.
Remember to label the issue with the appropriate area, and also assign it to yourself if you plan to work on the issue in the near future.
Describe the bug
Setting debug to true disables Purge Protection in the core
https://microsoft.github.io/AzureTRE/tre-admins/environment-variables/#for-shared-management-resources-in-devopsenv
Workspace are still created with Purge Protection enabled (and it cannot be disbaled)
Suggest that debug should consistently set Purge Protection for both core and workspace
This could be done by replicating the setting in
https://github.com/microsoft/AzureTRE/blob/main/templates/core/terraform/keyvault/keyvault.tf
to
https://github.com/microsoft/AzureTRE/blob/main/templates/workspaces/base/terraform/keyvault.tf
Steps to reproduce
The text was updated successfully, but these errors were encountered: