Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input for workspace is workspaceType - rename to templateName across resources for consistency #240

Closed
TessFerrandez opened this issue Jun 10, 2021 · 1 comment · Fixed by #1031
Closed

Input for workspace is workspaceType - rename to templateName across resources for consistency #240

TessFerrandez opened this issue Jun 10, 2021 · 1 comment · Fixed by #1031
Assignees
@marrobi
Labels
api Composition Service API good first issue Good for newcomers
Milestone
Release 0.4

Comments

@TessFerrandez
Copy link
Member

Input for workspace is workspaceType - rename to WorkspaceTemplateName for consistency
@TessFerrandez TessFerrandez added the api Composition Service API label Jun 10, 2021
@christoferlof christoferlof added the good first issue Good for newcomers label Jun 16, 2021
@christoferlof christoferlof added this to the Backlog milestone Jun 16, 2021
@marrobi
Copy link
Member

marrobi commented Aug 13, 2021

@TessFerrandez how about just TemplateName - then is some consistency across resources.

@marrobi marrobi changed the title Input for workspace is workspaceType - rename to WorkspaceTemplateName for consistency Input for workspace is workspaceType - rename to templateName for consistency Aug 26, 2021
@marrobi marrobi changed the title Input for workspace is workspaceType - rename to templateName for consistency Input for workspace is workspaceType - rename to templateName across resources for consistency Aug 26, 2021
@marrobi marrobi modified the milestones: Backlog, Release 0.3 Sep 14, 2021
@marrobi marrobi self-assigned this Oct 11, 2021
@marrobi marrobi mentioned this issue Oct 11, 2021
Merged
1 task
@marrobi marrobi linked a pull request Oct 11, 2021 that will close this issue
Rename workspaceType, workspaceServiceType and userResourceType to templateName #1031
Merged
1 task
marrobi added a commit that referenced this issue Oct 12, 2021
@marrobi
Input for workspace is workspaceType - rename to templateName across …

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
cb9b9ba 
…resources for consistency

Fixes #240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marrobi marrobi

Labels
api Composition Service API good first issue Good for newcomers
Projects
None yet
Milestone
Release 0.4
Development

Successfully merging a pull request may close this issue.

Rename workspaceType, workspaceServiceType and userResourceType to templateName microsoft/AzureTRE
3 participants
@christoferlof @TessFerrandez @marrobi