Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If Guacamole fails on install, upgrade does not recreate firewall rules. #3814

Open
marrobi opened this issue Dec 18, 2023 · 0 comments · May be fixed by #4343
Open

If Guacamole fails on install, upgrade does not recreate firewall rules. #3814

marrobi opened this issue Dec 18, 2023 · 0 comments · May be fixed by #4343
Labels
bug Something isn't working bundles Creating and deploying bundles/templates

Comments

@marrobi
Copy link
Member

marrobi commented Dec 18, 2023

We should look at adding firewall rule creation to the upgrade step in template schema.
@marrobi marrobi added the bug Something isn't working label Dec 18, 2023
@tim-p-allen tim-p-allen added the bundles Creating and deploying bundles/templates label May 8, 2024
marrobi added a commit that referenced this issue Feb 7, 2025
@marrobi
Fix firewall rules creation on upgrade for Guacamole
80de1a6 
Fixes #3814

Add firewall rule creation to the upgrade step in Guacamole template schema.

* Add a step to the `upgrade` section in `templates/workspace_services/guacamole/template_schema.json` to add network firewall rules for Guacamole.
* Ensure the new step in the `upgrade` section matches the step in the `install` section.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/3814?shareId=XXXX-XXXX-XXXX-XXXX).
@marrobi marrobi linked a pull request Feb 7, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working bundles Creating and deploying bundles/templates
Projects
Azure TRE - Engineering
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix firewall rules creation on upgrade for Guacamole microsoft/AzureTRE
2 participants
@marrobi @tim-p-allen