Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix firewall check in control script #1387

Merged
merged 2 commits into from
Feb 27, 2022
Merged

Fix firewall check in control script #1387

merged 2 commits into from
Feb 27, 2022

Conversation

tamirkamara
Copy link
Collaborator

What is being addressed

  1. Control script should check for firewall existence before trying to access its settings
  2. Destroy script now looks for diagnostic settings and deletes them before deleting the resource group. This is another step to allow reusing the same TREID

@tamirkamara tamirkamara requested a review from eladiw February 27, 2022 14:00
@github-actions
Copy link

github-actions bot commented Feb 27, 2022 •
edited
Loading

Unit Test Results

  1 files  ±  0    1 suites  ±0   12s ⏱️ - 20m 41s
14 tests +13  14 ✔️ +13  0 💤 ±0  0 ❌ ±0 

Results for commit 46cf6d1. ± Comparison against base commit 2831d5c.

This pull request removes 1 and adds 14 tests. Note that renamed tests count towards both. 
test_workspace_service_creation ‑ test_create_guacamole_service_into_base_workspace

test_workspace_creation ‑ test_get_workspace_templates[tre-workspace-base]
test_workspace_creation ‑ test_get_workspace_templates[tre-workspace-innereye]
test_workspace_creation ‑ test_getting_templates[tre-workspace-base]
test_workspace_creation ‑ test_getting_templates[tre-workspace-innereye]
test_workspace_service_creation ‑ test_get_workspace_service_templates[tre-service-azureml]
test_workspace_service_creation ‑ test_get_workspace_service_templates[tre-service-devtestlabs]
test_workspace_service_creation ‑ test_get_workspace_service_templates[tre-service-guacamole]
test_workspace_service_creation ‑ test_get_workspace_service_templates[tre-service-innereye]
test_workspace_service_creation ‑ test_getting_templates[tre-service-azureml]
test_workspace_service_creation ‑ test_getting_templates[tre-service-devtestlabs]
…

♻️ This comment has been updated with latest results.

@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 14:17 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 14:21 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 14:21 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 14:21 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 14:21 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 14:21 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 14:21 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 14:21 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 14:21 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 14:21 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 14:21 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 14:27 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 15:07 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 15:07 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 15:07 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 15:07 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 15:07 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 15:07 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 15:09 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 16:13 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 16:16 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 16:16 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 16:16 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 16:16 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 16:16 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 16:16 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 16:16 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 16:16 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 16:16 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 16:16 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 16:18 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 16:23 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 16:23 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 16:23 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 16:23 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 16:23 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 16:23 Inactive
@tamirkamara tamirkamara temporarily deployed to Dev February 27, 2022 16:25 Inactive
@tamirkamara tamirkamara merged commit 15868ad into main Feb 27, 2022
@tamirkamara tamirkamara deleted the tamirkamra/destroy-diag-settings branch February 27, 2022 17:20
@tamirkamara tamirkamara mentioned this pull request Feb 27, 2022
Merged
vjmanda added a commit to vjmanda/AzureTRE that referenced this pull request Mar 3, 2022
@vjmanda
Squashed commit of the following:
094decc 
commit 4ff39ce
Author: Stuart Leeks <[email protected]>
Date:   Wed Mar 2 15:31:28 2022 +0000

    remove duplicated step (microsoft#1419)

commit 06c1e4c
Author: Stuart Leeks <[email protected]>
Date:   Wed Mar 2 14:10:51 2022 +0000

    Update debugging for comment triggered workflow (microsoft#1415)

    * Fix up user permissions debugging

    * Add logging to PR details

commit e2d12c8
Author: Stuart Leeks <[email protected]>
Date:   Wed Mar 2 11:07:33 2022 +0000

    Add more debug info to help test permission checks (microsoft#1412)

commit fc091c7
Author: Stuart Leeks <[email protected]>
Date:   Wed Mar 2 10:09:47 2022 +0000

    Comment bot fixes (microsoft#1411)

    * Fix up tests for running build for main

    * Add Dev environment for az credentials for cleanup command

commit f6b25d1
Author: Tamir Kamara <[email protected]>
Date:   Wed Mar 2 09:39:24 2022 +0200

    Add header to RP prune script (microsoft#1400)

    * add script header

    * debug steps on destroy script

    * change query in the destroy script

commit 8022b7c
Author: Stuart Leeks <[email protected]>
Date:   Tue Mar 1 21:15:15 2022 +0000

    Add test-destroy-env command (microsoft#1410)

commit 7db9fca
Author: Stuart Leeks <[email protected]>
Date:   Tue Mar 1 20:09:41 2022 +0000

    Add explicit checks update for comment-triggered builds (microsoft#1408)

commit 607abde
Author: James Griffin <[email protected]>
Date:   Tue Mar 1 17:10:13 2022 +0000

    Implement custom actions (microsoft#1385)

    * Added action route

    * Handle custom actions in resource proc

    * Added catch for unsupported operation state changes

    * Added launch.json for resource proc debug

    * Updated res proc docs to make debugging easier

    * Added env sample

    * Consistency of custom_actions naming

    * Use invoke in runner

    * custom_actions camelcasing

    * Added template validation

    * Moved start stop to correct place

    * Fixed ubuntu default

    * Bumped version

    * Validate against template

    * Added workspace service name get

    * Added action routes to workspace and workspace services

    * Bump versions

    * Amended API permissions

    * Added action field to operation

    * PR amendments

    * Amended outputs and fixed sb tests

    * Fixed set()

    * Added pythonpath and pip install

    * Modified rp deploy to use new var names

    * Removed unused blocks and shortened debug setup for RP

    * reverted sb 503 -> 500

    * SB auth warning

    * Added use local creds flag

commit df8117c
Author: Oliver Atkinson <[email protected]>
Date:   Tue Mar 1 16:28:17 2022 +0000

    Shared workspace storage (microsoft#1339)

    * Added Shared Storage Access to Linux VM

    * Added vm shared storage to basic SA deployment

    * Changed hard coded value to data reference

    * Shared Storage access added

    * Windows Shared Storage Fixed

    * Changed incorrect default image

    * fixed typo

    * Windows Shared Storage fix

    * Added initial storage mount

    * removed trailing \ from command

    * Link to shared folder created

    * Corrected version number

    * Added back incorrectly removed char

    * Set drive to be added globally

    * Ammended paths used

    * set cmdkey to add to admin users account

    * Set cmdkey add as start-up script

    * Fixed shared storage access

    * Moved shared storage to workspace level

    * Merged shared storage changes

    * Ommited shared storage name from template

    * Ommiting shared storage access from schema

    * granted rw on fileshare to any linux vm user

    * Iterate workspace build number

    * Fixed lint issues

    Co-authored-by: Ross Smith <[email protected]>

commit 9dc4ccb
Author: Stuart Leeks <[email protected]>
Date:   Tue Mar 1 14:54:56 2022 +0000

    fixup typo (microsoft#1404)

    * fixup typo

    * Update condition on pr details step

    * Update command name (test-force-approve)

commit 9d29ba5
Author: Stuart Leeks <[email protected]>
Date:   Tue Mar 1 12:29:04 2022 +0000

    Update to use PR head sha for md-only checks (microsoft#1402)

    * Add debug output

    * Use PR head sha for checks

commit 8c6bc85
Author: Tamir Kamara <[email protected]>
Date:   Tue Mar 1 08:34:21 2022 +0200

    Make uses destroy script (microsoft#1392)

    * make uses destroy script

    * bug fix

    * fix field typo

commit 35e0481
Author: Tamir Kamara <[email protected]>
Date:   Mon Feb 28 15:09:56 2022 +0200

    tre-start called before deploy-core (microsoft#1391)

commit 858f013
Author: Oliver Atkinson <[email protected]>
Date:   Mon Feb 28 09:55:26 2022 +0000

    Guacamole Service properties documentation (microsoft#1380)

    * Documented Guacamole Service exposed properties

    * Reworded based on suggestions

    Co-authored-by: Elad Iwanir <[email protected]>

    * Split properties into required and optional

    Co-authored-by: Tamir Kamara <[email protected]>
    Co-authored-by: Elad Iwanir <[email protected]>

commit d066b94
Author: Tamir Kamara <[email protected]>
Date:   Mon Feb 28 10:03:31 2022 +0200

    Diagnostic settings support only sync deletion  (microsoft#1388)

    * fix bug

    * delete diagnostics in parallel

commit 15868ad
Author: Tamir Kamara <[email protected]>
Date:   Sun Feb 27 19:20:22 2022 +0200

    Fix firewall check in control script  (microsoft#1387)

    * fix control script checking firewall

    * adding echo

commit 2831d5c
Author: Elad Iwanir <[email protected]>
Date:   Sun Feb 27 15:21:47 2022 +0200

    Adding ID token (hybrid flow) to the app registration script (microsoft#1353)

    * Adding ID token (hybrid flow) to the app registration script

    * adding missing optional claims + api permissions

    * Adding vars to scope ids

commit a83c33b
Author: Tamir Kamara <[email protected]>
Date:   Sun Feb 27 10:58:02 2022 +0200

    checkout without persisting credentials (microsoft#1374)

commit 18b9e8f
Author: Stuart Leeks <[email protected]>
Date:   Sat Feb 26 15:38:59 2022 +0000

    Add link to workflow run (microsoft#1384)

    * Explicitly set SHA for checks status

    * Add link to workflow run in PR comment

commit 561b482
Author: Stuart Leeks <[email protected]>
Date:   Fri Feb 25 15:12:52 2022 +0000

    Fix ordering. Update to use PR merge ref (microsoft#1383)

commit ce3ddb9
Author: David Moore <[email protected]>
Date:   Fri Feb 25 13:46:14 2022 +0000

    Split out Firewall / Nexus / Gitea (microsoft#1365)

    * WIP: doesn't work yet

    * Make temporary changes to the makefile

    * Fixes to firewall submodule

    * Update Makefile

    * move firewall name to locals

    * Init porter bundles for Gitea and Nexus

    * Add parameters to the new porter bundles

    * Revert "Convert data inputs into variable inputs for modules in Terraform (microsoft#1154)"

    This reverts commit c3e2cb7.

    * WIP: moving variables around for Gitea

    * Update Gitea module to consume variables from data

    * Fix several problems in firewall module

    * Changes to Gitea terraform (fix state container, add az login for local-exec)

    * Initial Nexus porter configuration

    * Add Sonatype-Nexus bundle

    * Uncomment firewall lock, fix local-exec command

    * Fix comments

    * fmt

    * Gitea, Nexus: Move variable inputs to data and locals

    * change path to nexus.properties

    * temporarily remove arm_client_id

    * fmt

    * remove unused arguments

    * fmt

    * Use key_vault_reference_identity_id in Terraform

    * Remove unused variables

    * Deploy Firewall, Gitea and Nexus as part of the main build

    * Add deploying of shared services to tre-deploy command

    * Add uninstall back

    * WIP: working transfer of state for Firewall

    * WIP: fiddling with more states

    * WIP: fix removal of terraform state

    * Add import script for Gitea

    * fixup tre-start/stop make target naming

    * strip '-' from string in storage account name

    * removed state_remove for gitea + nexus

    * removed state_remove for gitea + nexus

    * local modifications of import/remove state scripts

    * fw / gitea / nexus deploy from local via tf functional

    * gitignore

    * bumped gitea version

    * tf linting

    * PR updates

    * vars for ci

    * added check_dependencies to login in CI

    * check for non-existing RG and skipping import state if we're in a fresh CI

    * removed lock from remove/import scripts

    * remove/import state for gitea

    * gitea and nexus state moved

    * nexus + gitea state moved, apart from storage share

    * fixed storage import

    * PR snags

    * override

    * kv uri

    * new secret import style

    * secret

    * secret

    * state list

    * state list

    * remove state fix

    * remove state special chars

    * importing random_password to prevent KV updating

    * moved make target out of default path

    * supress risky log output

    * unwound gitea/nexus state moving debacle

    Co-authored-by: Tanya Borisova <[email protected]>
    Co-authored-by: Ross Smith <[email protected]>
    Co-authored-by: Stuart Leeks <[email protected]>

commit c2742f6
Author: Stuart Leeks <[email protected]>
Date:   Fri Feb 25 11:34:03 2022 +0000

    Fixes for pr_comment_bot (microsoft#1382)

    * Fixup checkout steps across jobs

    * Add persist-credentials=false

    * Set repo/ref on checkout for filter

commit 0be8fe0
Author: Stuart Leeks <[email protected]>
Date:   Fri Feb 25 08:26:11 2022 +0000

    Revert to author_association checks (microsoft#1379)

commit b238e28
Author: Tamir Kamara <[email protected]>
Date:   Thu Feb 24 19:30:36 2022 +0200

    delete env in script (microsoft#1372)

commit 3a2a64e
Author: Stuart Leeks <[email protected]>
Date:   Thu Feb 24 16:31:25 2022 +0000

    Add error to output (microsoft#1378)

commit 7917439
Author: Stuart Leeks <[email protected]>
Date:   Thu Feb 24 15:49:48 2022 +0000

    Add output to diagnose permissions + start force-approve command (microsoft#1377)

    * Make message more informative

    * Add extra details to log messages

    * Add force-approve command

commit 39a3a9c
Author: Stuart Leeks <[email protected]>
Date:   Thu Feb 24 14:59:49 2022 +0000

    Move user check inside workflow step (microsoft#1375)

commit 2495fdf
Author: Stuart Leeks <[email protected]>
Date:   Thu Feb 24 11:32:50 2022 +0000

    Add temp debug step (microsoft#1373)

commit df61a4d
Author: Martin Peck <[email protected]>
Date:   Thu Feb 24 10:29:57 2022 +0000

    allow all fw rules to be dropped (microsoft#1369)

commit 44522a3
Author: Stuart Leeks <[email protected]>
Date:   Thu Feb 24 09:44:23 2022 +0000

    Fix output reference (microsoft#1371)

commit d34bf0c
Author: Stuart Leeks <[email protected]>
Date:   Thu Feb 24 08:24:04 2022 +0000

    Add pr_comment_bot workflow (microsoft#1356)

    * Add pr_comment_bot workflow

    Allow running tests by commenting "/test" on a PR as OWNER/COLLABORATOR

    * Revert TRE_ID to git ref

    Based on discussion with @tamirkamara, changing this ID would require changes in numerous places in the scripts etc

    * Switch to standard checkout action for PR code

    * Add filter to skip full build on MD-only changes

    * Update references to CI github ref

    * fix quotes

    * Update comment/name

    * Update job name to align with manual check status

commit 4df245f
Author: Martin Peck <[email protected]>
Date:   Wed Feb 23 14:08:06 2022 +0000

    set exit codes to 1 (microsoft#1364)

commit ca7bb00
Author: Tamir Kamara <[email protected]>
Date:   Tue Feb 22 22:04:13 2022 +0200

    ci checks core image version update (microsoft#1360)

commit 78815fc
Author: Tamir Kamara <[email protected]>
Date:   Tue Feb 22 21:22:41 2022 +0200

    update rp to free disk space (microsoft#1358)

commit 31ca745
Author: Tamir Kamara <[email protected]>
Date:   Tue Feb 22 11:21:23 2022 +0200

    Fix debug reference in docs (microsoft#1357)

    * fix debug reference in docs

    * docs published only if needed

commit 383c7f8
Author: Tamir Kamara <[email protected]>
Date:   Mon Feb 21 18:38:49 2022 +0200

    Skip deploy when only md files are updated (microsoft#1351)

    * run workflow steps when needed

    * update comment

commit a9ec4d3
Author: Tamir Kamara <[email protected]>
Date:   Mon Feb 21 17:46:34 2022 +0200

    Upgrade azurerm to 2.97 (microsoft#1354)

    * upgrade azurerm to 2.97

    * format fix

commit 8602c57
Author: Elad Iwanir <[email protected]>
Date:   Mon Feb 21 10:27:50 2022 +0200

    Fix broken doc link (microsoft#1350)

commit 36c5f37
Author: Jamie D <[email protected]>
Date:   Sun Feb 20 17:03:33 2022 +0000

    Reminder to update docs when making changes (microsoft#1341)

    Co-authored-by: Jamie D <[email protected]>
    Co-authored-by: Tamir Kamara <[email protected]>

commit 0cbf3d2
Author: Stuart Leeks <[email protected]>
Date:   Sun Feb 20 15:51:18 2022 +0000

    Add firewall dependency for gitea/nexus (microsoft#1334)

    Co-authored-by: Ross Smith <[email protected]>
    Co-authored-by: Tamir Kamara <[email protected]>

commit abc6e6a
Author: Tamir Kamara <[email protected]>
Date:   Sun Feb 20 17:25:03 2022 +0200

    Fix CI ACR Cache Parameter (microsoft#1347)

    * fix CI_CACHE_ACR_NAME

    * Install az extensions as needed

    Co-authored-by: Elad Iwanir <[email protected]>

commit 9315964
Author: Elad Iwanir <[email protected]>
Date:   Sun Feb 20 16:53:36 2022 +0200

    add print (microsoft#1348)

commit 06d6f95
Author: Elad Iwanir <[email protected]>
Date:   Sun Feb 20 14:50:05 2022 +0200

    Fix extended tests results publishing (microsoft#1345)

commit 5375ba5
Author: Tamir Kamara <[email protected]>
Date:   Sun Feb 20 12:13:11 2022 +0200

    Fix cleanup script/workflows with no locks (microsoft#1328)

    * fix cleanup with no locks

    * typo

    * fix control-tre script

    * keyvault issue

    * Revert "keyvault issue"

    This reverts commit 123f05c.

commit 9ecf86e
Author: Tamir Kamara <[email protected]>
Date:   Sun Feb 20 11:53:07 2022 +0200

    Stop inactive CI environments (microsoft#1318)

    * enable tre stop/start

    * tiny update

    * ci to stop envs after inactivity

    * keyvault issue

    * Revert "keyvault issue"

    This reverts commit 710fe47.

commit df67ec4
Author: Tamir Kamara <[email protected]>
Date:   Sun Feb 20 09:13:48 2022 +0200

    load core env for tre-destroy (microsoft#1329)

commit c6ab21c
Author: Ross Smith <[email protected]>
Date:   Fri Feb 18 13:38:34 2022 +0000

    Removed .vscode files (microsoft#1331)

    * Removed .vscode files

    * Format document

    Co-authored-by: Jamie D <[email protected]>

commit 85bb666
Author: Ross Smith <[email protected]>
Date:   Fri Feb 18 13:28:23 2022 +0000

    typo (microsoft#1337)

    Co-authored-by: Jamie D <[email protected]>

commit 4f5bab9
Author: vjmanda <[email protected]>
Date:   Fri Feb 18 12:54:03 2022 +0000

    microsoft#1309-Fix-DocumentationCorrectionsAndFormatting (microsoft#1312)

    Co-authored-by: Vijay Manda <[email protected]>
    Co-authored-by: Ross Smith <[email protected]>

commit 2f462c4
Author: Elad Iwanir <[email protected]>
Date:   Fri Feb 18 13:16:44 2022 +0200

    Adding a job to run extended tests (only on main) (microsoft#1322)

    * Adding a job to run extended tests (only on main)

    * add missing devcontainer tag

    Co-authored-by: Ross Smith <[email protected]>

commit c22a6f6
Author: Tamir Kamara <[email protected]>
Date:   Fri Feb 18 12:57:30 2022 +0200

    Add secondary docker cache (microsoft#1323)

    * add secondary docker cache

    * change acr name

    Co-authored-by: Ross Smith <[email protected]>

commit 79260e0
Author: Jamie D <[email protected]>
Date:   Fri Feb 18 10:02:36 2022 +0000

    microsoft#1326 (microsoft#1327)

    Co-authored-by: Jamie D <[email protected]>
martinpeck added a commit that referenced this pull request Mar 21, 2022
@vjmanda @tamirkamara @martinpeck
Add mlflow as workspace service (#1389)
09104b6 
* #1290-CodeEnhancements

* #1290-AddMLflowWorkspaceServiceAndDockerImage

* #1290-AddMLflowPostgresqlDB

* #1290-ReducePostgresqlSKUAndStorage

* #1290-FixFilePathsInDockerfile

* Update local reference

Co-authored-by: Tamir Kamara <[email protected]>

* Update terraform porter mixin version

Co-authored-by: Tamir Kamara <[email protected]>

* Update terraform version

Co-authored-by: Tamir Kamara <[email protected]>

* Remove redundant code

* ParameteriseWebExternalExposure

* SetMLflowVersionAndRemoveRedundantCode

* AddPostgreSQLVirtualNetworkRule

* ResolveFileShareConflictDuringDeployment

* #1290-CodeEnhancements

* #1290-AddMLflowWorkspaceServiceAndDockerImage

* #1290-AddMLflowPostgresqlDB

* #1290-ReducePostgresqlSKUAndStorage

* #1290-FixFilePathsInDockerfile

* Update local reference

Co-authored-by: Tamir Kamara <[email protected]>

* Update terraform porter mixin version

Co-authored-by: Tamir Kamara <[email protected]>

* Update terraform version

Co-authored-by: Tamir Kamara <[email protected]>

* Remove redundant code

* ParameteriseWebExternalExposure

* SetMLflowVersionAndRemoveRedundantCode

* AddPostgreSQLVirtualNetworkRule

* ResolveFileShareConflictDuringDeployment

* Squashed commit of the following:

commit 4ff39ce
Author: Stuart Leeks <[email protected]>
Date:   Wed Mar 2 15:31:28 2022 +0000

    remove duplicated step (#1419)

commit 06c1e4c
Author: Stuart Leeks <[email protected]>
Date:   Wed Mar 2 14:10:51 2022 +0000

    Update debugging for comment triggered workflow (#1415)

    * Fix up user permissions debugging

    * Add logging to PR details

commit e2d12c8
Author: Stuart Leeks <[email protected]>
Date:   Wed Mar 2 11:07:33 2022 +0000

    Add more debug info to help test permission checks (#1412)

commit fc091c7
Author: Stuart Leeks <[email protected]>
Date:   Wed Mar 2 10:09:47 2022 +0000

    Comment bot fixes (#1411)

    * Fix up tests for running build for main

    * Add Dev environment for az credentials for cleanup command

commit f6b25d1
Author: Tamir Kamara <[email protected]>
Date:   Wed Mar 2 09:39:24 2022 +0200

    Add header to RP prune script (#1400)

    * add script header

    * debug steps on destroy script

    * change query in the destroy script

commit 8022b7c
Author: Stuart Leeks <[email protected]>
Date:   Tue Mar 1 21:15:15 2022 +0000

    Add test-destroy-env command (#1410)

commit 7db9fca
Author: Stuart Leeks <[email protected]>
Date:   Tue Mar 1 20:09:41 2022 +0000

    Add explicit checks update for comment-triggered builds (#1408)

commit 607abde
Author: James Griffin <[email protected]>
Date:   Tue Mar 1 17:10:13 2022 +0000

    Implement custom actions (#1385)

    * Added action route

    * Handle custom actions in resource proc

    * Added catch for unsupported operation state changes

    * Added launch.json for resource proc debug

    * Updated res proc docs to make debugging easier

    * Added env sample

    * Consistency of custom_actions naming

    * Use invoke in runner

    * custom_actions camelcasing

    * Added template validation

    * Moved start stop to correct place

    * Fixed ubuntu default

    * Bumped version

    * Validate against template

    * Added workspace service name get

    * Added action routes to workspace and workspace services

    * Bump versions

    * Amended API permissions

    * Added action field to operation

    * PR amendments

    * Amended outputs and fixed sb tests

    * Fixed set()

    * Added pythonpath and pip install

    * Modified rp deploy to use new var names

    * Removed unused blocks and shortened debug setup for RP

    * reverted sb 503 -> 500

    * SB auth warning

    * Added use local creds flag

commit df8117c
Author: Oliver Atkinson <[email protected]>
Date:   Tue Mar 1 16:28:17 2022 +0000

    Shared workspace storage (#1339)

    * Added Shared Storage Access to Linux VM

    * Added vm shared storage to basic SA deployment

    * Changed hard coded value to data reference

    * Shared Storage access added

    * Windows Shared Storage Fixed

    * Changed incorrect default image

    * fixed typo

    * Windows Shared Storage fix

    * Added initial storage mount

    * removed trailing \ from command

    * Link to shared folder created

    * Corrected version number

    * Added back incorrectly removed char

    * Set drive to be added globally

    * Ammended paths used

    * set cmdkey to add to admin users account

    * Set cmdkey add as start-up script

    * Fixed shared storage access

    * Moved shared storage to workspace level

    * Merged shared storage changes

    * Ommited shared storage name from template

    * Ommiting shared storage access from schema

    * granted rw on fileshare to any linux vm user

    * Iterate workspace build number

    * Fixed lint issues

    Co-authored-by: Ross Smith <[email protected]>

commit 9dc4ccb
Author: Stuart Leeks <[email protected]>
Date:   Tue Mar 1 14:54:56 2022 +0000

    fixup typo (#1404)

    * fixup typo

    * Update condition on pr details step

    * Update command name (test-force-approve)

commit 9d29ba5
Author: Stuart Leeks <[email protected]>
Date:   Tue Mar 1 12:29:04 2022 +0000

    Update to use PR head sha for md-only checks (#1402)

    * Add debug output

    * Use PR head sha for checks

commit 8c6bc85
Author: Tamir Kamara <[email protected]>
Date:   Tue Mar 1 08:34:21 2022 +0200

    Make uses destroy script (#1392)

    * make uses destroy script

    * bug fix

    * fix field typo

commit 35e0481
Author: Tamir Kamara <[email protected]>
Date:   Mon Feb 28 15:09:56 2022 +0200

    tre-start called before deploy-core (#1391)

commit 858f013
Author: Oliver Atkinson <[email protected]>
Date:   Mon Feb 28 09:55:26 2022 +0000

    Guacamole Service properties documentation (#1380)

    * Documented Guacamole Service exposed properties

    * Reworded based on suggestions

    Co-authored-by: Elad Iwanir <[email protected]>

    * Split properties into required and optional

    Co-authored-by: Tamir Kamara <[email protected]>
    Co-authored-by: Elad Iwanir <[email protected]>

commit d066b94
Author: Tamir Kamara <[email protected]>
Date:   Mon Feb 28 10:03:31 2022 +0200

    Diagnostic settings support only sync deletion  (#1388)

    * fix bug

    * delete diagnostics in parallel

commit 15868ad
Author: Tamir Kamara <[email protected]>
Date:   Sun Feb 27 19:20:22 2022 +0200

    Fix firewall check in control script  (#1387)

    * fix control script checking firewall

    * adding echo

commit 2831d5c
Author: Elad Iwanir <[email protected]>
Date:   Sun Feb 27 15:21:47 2022 +0200

    Adding ID token (hybrid flow) to the app registration script (#1353)

    * Adding ID token (hybrid flow) to the app registration script

    * adding missing optional claims + api permissions

    * Adding vars to scope ids

commit a83c33b
Author: Tamir Kamara <[email protected]>
Date:   Sun Feb 27 10:58:02 2022 +0200

    checkout without persisting credentials (#1374)

commit 18b9e8f
Author: Stuart Leeks <[email protected]>
Date:   Sat Feb 26 15:38:59 2022 +0000

    Add link to workflow run (#1384)

    * Explicitly set SHA for checks status

    * Add link to workflow run in PR comment

commit 561b482
Author: Stuart Leeks <[email protected]>
Date:   Fri Feb 25 15:12:52 2022 +0000

    Fix ordering. Update to use PR merge ref (#1383)

commit ce3ddb9
Author: David Moore <[email protected]>
Date:   Fri Feb 25 13:46:14 2022 +0000

    Split out Firewall / Nexus / Gitea (#1365)

    * WIP: doesn't work yet

    * Make temporary changes to the makefile

    * Fixes to firewall submodule

    * Update Makefile

    * move firewall name to locals

    * Init porter bundles for Gitea and Nexus

    * Add parameters to the new porter bundles

    * Revert "Convert data inputs into variable inputs for modules in Terraform (#1154)"

    This reverts commit c3e2cb7.

    * WIP: moving variables around for Gitea

    * Update Gitea module to consume variables from data

    * Fix several problems in firewall module

    * Changes to Gitea terraform (fix state container, add az login for local-exec)

    * Initial Nexus porter configuration

    * Add Sonatype-Nexus bundle

    * Uncomment firewall lock, fix local-exec command

    * Fix comments

    * fmt

    * Gitea, Nexus: Move variable inputs to data and locals

    * change path to nexus.properties

    * temporarily remove arm_client_id

    * fmt

    * remove unused arguments

    * fmt

    * Use key_vault_reference_identity_id in Terraform

    * Remove unused variables

    * Deploy Firewall, Gitea and Nexus as part of the main build

    * Add deploying of shared services to tre-deploy command

    * Add uninstall back

    * WIP: working transfer of state for Firewall

    * WIP: fiddling with more states

    * WIP: fix removal of terraform state

    * Add import script for Gitea

    * fixup tre-start/stop make target naming

    * strip '-' from string in storage account name

    * removed state_remove for gitea + nexus

    * removed state_remove for gitea + nexus

    * local modifications of import/remove state scripts

    * fw / gitea / nexus deploy from local via tf functional

    * gitignore

    * bumped gitea version

    * tf linting

    * PR updates

    * vars for ci

    * added check_dependencies to login in CI

    * check for non-existing RG and skipping import state if we're in a fresh CI

    * removed lock from remove/import scripts

    * remove/import state for gitea

    * gitea and nexus state moved

    * nexus + gitea state moved, apart from storage share

    * fixed storage import

    * PR snags

    * override

    * kv uri

    * new secret import style

    * secret

    * secret

    * state list

    * state list

    * remove state fix

    * remove state special chars

    * importing random_password to prevent KV updating

    * moved make target out of default path

    * supress risky log output

    * unwound gitea/nexus state moving debacle

    Co-authored-by: Tanya Borisova <[email protected]>
    Co-authored-by: Ross Smith <[email protected]>
    Co-authored-by: Stuart Leeks <[email protected]>

commit c2742f6
Author: Stuart Leeks <[email protected]>
Date:   Fri Feb 25 11:34:03 2022 +0000

    Fixes for pr_comment_bot (#1382)

    * Fixup checkout steps across jobs

    * Add persist-credentials=false

    * Set repo/ref on checkout for filter

commit 0be8fe0
Author: Stuart Leeks <[email protected]>
Date:   Fri Feb 25 08:26:11 2022 +0000

    Revert to author_association checks (#1379)

commit b238e28
Author: Tamir Kamara <[email protected]>
Date:   Thu Feb 24 19:30:36 2022 +0200

    delete env in script (#1372)

commit 3a2a64e
Author: Stuart Leeks <[email protected]>
Date:   Thu Feb 24 16:31:25 2022 +0000

    Add error to output (#1378)

commit 7917439
Author: Stuart Leeks <[email protected]>
Date:   Thu Feb 24 15:49:48 2022 +0000

    Add output to diagnose permissions + start force-approve command (#1377)

    * Make message more informative

    * Add extra details to log messages

    * Add force-approve command

commit 39a3a9c
Author: Stuart Leeks <[email protected]>
Date:   Thu Feb 24 14:59:49 2022 +0000

    Move user check inside workflow step (#1375)

commit 2495fdf
Author: Stuart Leeks <[email protected]>
Date:   Thu Feb 24 11:32:50 2022 +0000

    Add temp debug step (#1373)

commit df61a4d
Author: Martin Peck <[email protected]>
Date:   Thu Feb 24 10:29:57 2022 +0000

    allow all fw rules to be dropped (#1369)

commit 44522a3
Author: Stuart Leeks <[email protected]>
Date:   Thu Feb 24 09:44:23 2022 +0000

    Fix output reference (#1371)

commit d34bf0c
Author: Stuart Leeks <[email protected]>
Date:   Thu Feb 24 08:24:04 2022 +0000

    Add pr_comment_bot workflow (#1356)

    * Add pr_comment_bot workflow

    Allow running tests by commenting "/test" on a PR as OWNER/COLLABORATOR

    * Revert TRE_ID to git ref

    Based on discussion with @tamirkamara, changing this ID would require changes in numerous places in the scripts etc

    * Switch to standard checkout action for PR code

    * Add filter to skip full build on MD-only changes

    * Update references to CI github ref

    * fix quotes

    * Update comment/name

    * Update job name to align with manual check status

commit 4df245f
Author: Martin Peck <[email protected]>
Date:   Wed Feb 23 14:08:06 2022 +0000

    set exit codes to 1 (#1364)

commit ca7bb00
Author: Tamir Kamara <[email protected]>
Date:   Tue Feb 22 22:04:13 2022 +0200

    ci checks core image version update (#1360)

commit 78815fc
Author: Tamir Kamara <[email protected]>
Date:   Tue Feb 22 21:22:41 2022 +0200

    update rp to free disk space (#1358)

commit 31ca745
Author: Tamir Kamara <[email protected]>
Date:   Tue Feb 22 11:21:23 2022 +0200

    Fix debug reference in docs (#1357)

    * fix debug reference in docs

    * docs published only if needed

commit 383c7f8
Author: Tamir Kamara <[email protected]>
Date:   Mon Feb 21 18:38:49 2022 +0200

    Skip deploy when only md files are updated (#1351)

    * run workflow steps when needed

    * update comment

commit a9ec4d3
Author: Tamir Kamara <[email protected]>
Date:   Mon Feb 21 17:46:34 2022 +0200

    Upgrade azurerm to 2.97 (#1354)

    * upgrade azurerm to 2.97

    * format fix

commit 8602c57
Author: Elad Iwanir <[email protected]>
Date:   Mon Feb 21 10:27:50 2022 +0200

    Fix broken doc link (#1350)

commit 36c5f37
Author: Jamie D <[email protected]>
Date:   Sun Feb 20 17:03:33 2022 +0000

    Reminder to update docs when making changes (#1341)

    Co-authored-by: Jamie D <[email protected]>
    Co-authored-by: Tamir Kamara <[email protected]>

commit 0cbf3d2
Author: Stuart Leeks <[email protected]>
Date:   Sun Feb 20 15:51:18 2022 +0000

    Add firewall dependency for gitea/nexus (#1334)

    Co-authored-by: Ross Smith <[email protected]>
    Co-authored-by: Tamir Kamara <[email protected]>

commit abc6e6a
Author: Tamir Kamara <[email protected]>
Date:   Sun Feb 20 17:25:03 2022 +0200

    Fix CI ACR Cache Parameter (#1347)

    * fix CI_CACHE_ACR_NAME

    * Install az extensions as needed

    Co-authored-by: Elad Iwanir <[email protected]>

commit 9315964
Author: Elad Iwanir <[email protected]>
Date:   Sun Feb 20 16:53:36 2022 +0200

    add print (#1348)

commit 06d6f95
Author: Elad Iwanir <[email protected]>
Date:   Sun Feb 20 14:50:05 2022 +0200

    Fix extended tests results publishing (#1345)

commit 5375ba5
Author: Tamir Kamara <[email protected]>
Date:   Sun Feb 20 12:13:11 2022 +0200

    Fix cleanup script/workflows with no locks (#1328)

    * fix cleanup with no locks

    * typo

    * fix control-tre script

    * keyvault issue

    * Revert "keyvault issue"

    This reverts commit 123f05c.

commit 9ecf86e
Author: Tamir Kamara <[email protected]>
Date:   Sun Feb 20 11:53:07 2022 +0200

    Stop inactive CI environments (#1318)

    * enable tre stop/start

    * tiny update

    * ci to stop envs after inactivity

    * keyvault issue

    * Revert "keyvault issue"

    This reverts commit 710fe47.

commit df67ec4
Author: Tamir Kamara <[email protected]>
Date:   Sun Feb 20 09:13:48 2022 +0200

    load core env for tre-destroy (#1329)

commit c6ab21c
Author: Ross Smith <[email protected]>
Date:   Fri Feb 18 13:38:34 2022 +0000

    Removed .vscode files (#1331)

    * Removed .vscode files

    * Format document

    Co-authored-by: Jamie D <[email protected]>

commit 85bb666
Author: Ross Smith <[email protected]>
Date:   Fri Feb 18 13:28:23 2022 +0000

    typo (#1337)

    Co-authored-by: Jamie D <[email protected]>

commit 4f5bab9
Author: vjmanda <[email protected]>
Date:   Fri Feb 18 12:54:03 2022 +0000

    #1309-Fix-DocumentationCorrectionsAndFormatting (#1312)

    Co-authored-by: Vijay Manda <[email protected]>
    Co-authored-by: Ross Smith <[email protected]>

commit 2f462c4
Author: Elad Iwanir <[email protected]>
Date:   Fri Feb 18 13:16:44 2022 +0200

    Adding a job to run extended tests (only on main) (#1322)

    * Adding a job to run extended tests (only on main)

    * add missing devcontainer tag

    Co-authored-by: Ross Smith <[email protected]>

commit c22a6f6
Author: Tamir Kamara <[email protected]>
Date:   Fri Feb 18 12:57:30 2022 +0200

    Add secondary docker cache (#1323)

    * add secondary docker cache

    * change acr name

    Co-authored-by: Ross Smith <[email protected]>

commit 79260e0
Author: Jamie D <[email protected]>
Date:   Fri Feb 18 10:02:36 2022 +0000

    #1326 (#1327)

    Co-authored-by: Jamie D <[email protected]>

* #1290-SharedStorageAndDocker

* Fix connectivity and issues

* Postgres Private DNS zone

* webapp use vnet_route_all_enabled

* Resolving comments and issues

* Add newline to dockerignore

* add mlflow to gh actions workflow

* Fixing artifact tracking issue

* Add documentation and tidy-up

Co-authored-by: Vijay Manda <[email protected]>
Co-authored-by: Tamir Kamara <[email protected]>
Co-authored-by: Martin Peck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladiw eladiw eladiw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamirkamara @eladiw