Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update obsolete TF properties #4136

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

tamirkamara
Copy link
Collaborator

What is being addressed

Some of the properties name have been replaced in the Terraform configuration files.

How is this addressed

  • Use up-to-date property names

Copy link

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 77fc88f.

@tamirkamara
Copy link
Collaborator Author

/test

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/11824451924 (with refid cf2c9b73)

(in response to this comment from @tamirkamara)

@marrobi marrobi self-requested a review November 13, 2024 20:11
Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, don't forget the changelog! Thanks.

Copy link
Collaborator

@tim-p-allen tim-p-allen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tim-p-allen tim-p-allen merged commit 158dce1 into main Nov 13, 2024
13 checks passed
@tim-p-allen tim-p-allen deleted the tamirkamara/update-terraform-warnings branch November 13, 2024 22:50
@marrobi
Copy link
Member

marrobi commented Nov 13, 2024

@tamirkamara you didn't update the changelog!

@tamirkamara
Copy link
Collaborator Author

I know @marrobi. I opened the PR, started the test, went to sleep and this morning saw it's merged. You and @tim-allen-ck were quick.
I will open a small one to add a changelog the this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants