Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux VM script fixes #4185

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Linux VM script fixes #4185

merged 4 commits into from
Dec 11, 2024

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Dec 11, 2024 •
edited
Loading

Fixes #4184

  • Add a polkit rule to allow color profile creation without authentication in the Linux VM.
  • pre set vscode repo settings to prevent interactive dialog
  • remote restart command to ensure cloud config reports successful completion (it always failed as system would reboot)
  • move xrdp to end of script to prevent users connecting while installations in progress.

@marrobi
Fix color profile authentication required dialog in Linux VM
bc3be1d 
Fixes #4184

Add a polkit rule to allow color profile creation without authentication in the Linux VM.

* **vm_config.sh**
  - Add a new section to create a polkit rule to allow color profile creation without authentication.
  - Use the provided script to create the polkit rule.
  - Ensure the script is executed with sudo privileges.

* **CHANGELOG.md**
  - Add entry to the changelog referencing the issue number.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/4184?shareId=XXXX-XXXX-XXXX-XXXX).
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit e457f60.

♻️ This comment has been updated with latest results.

@marrobi marrobi marked this pull request as draft December 11, 2024 13:46
@marrobi marrobi changed the title Fix color profile authentication required dialog in Linux VM Linux VM script fixes Dec 11, 2024
@marrobi marrobi marked this pull request as ready for review December 11, 2024 13:50
tim-p-allen
tim-p-allen approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@tim-p-allen tim-p-allen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to update the resource version

jonnyry
jonnyry approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@jonnyry jonnyry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not had chance to test but LGTM

@marrobi
Copy link
Member Author

marrobi commented Dec 11, 2024

/test-force-approve

Not covered by tests

@marrobi marrobi enabled auto-merge (squash) December 11, 2024 14:18
@github-actions GitHub Actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit e457f60)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit 6f4220f into main Dec 11, 2024
12 checks passed
@marrobi marrobi deleted the marrobi/fix-color-profile-authentication branch December 11, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnyry jonnyry jonnyry approved these changes

@tim-p-allen tim-p-allen tim-p-allen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linux VM generates authentication required to create a color profile dialog.
3 participants
@marrobi @jonnyry @tim-p-allen