-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the way "inherited" workspaces retrieve the base workspace code #4190
Change the way "inherited" workspaces retrieve the base workspace code #4190
Conversation
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 177c97d. ♻️ This comment has been updated with latest results. |
so do you need to have built |
you don't need to have |
Ahh got you. Nice. Happy to approve will test later |
/test f6255a6 |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12306981977 (with refid (in response to this comment from @tim-allen-ck) |
/test 8475e2a |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12314479660 (with refid (in response to this comment from @jonnyry) |
/test 43d4a60 |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12314638144 (with refid (in response to this comment from @jonnyry) |
Made a change so that the
In all other cases, the The |
Yes indeed. I have requested a patch release, though I don't think its quite as quick and simple as a release of the mixins - they are discussing and will get back to me. |
Porter have released version v1.2.1 incorporating the change. https://github.com/getporter/porter/releases/tag/v1.2.1 |
/test 184b000 |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12458499867 (with refid (in response to this comment from @jonnyry) |
/test-destroy-env |
Destroying PR test environment (RG: rg-trebc30f232)... (run: https://github.com/microsoft/AzureTRE/actions/runs/12463669373) |
PR test environment destroy complete (RG: rg-trebc30f232) |
/test 184b000 |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12464141375 (with refid (in response to this comment from @jonnyry) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as tested to work, looks great. Thanks again!
/test 177c97d |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12471249205 (with refid (in response to this comment from @jonnyry) |
Resolves #4162
What is being addressed
Change the way inherited workspaces retrieve the base workspace code - see solution description in #4162
Notes
1. Currently requires the 'canary' release of porter. Ideally this should be a pinned version, however we are waiting for a new version release which includes the --build-context parameter.(Now resolved - Porter have release version v1.2.1 incorporating the change.)