Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update aiohttp #4197

Merged
merged 12 commits into from
Dec 18, 2024
Merged

Update aiohttp #4197

merged 12 commits into from
Dec 18, 2024

Conversation

tim-p-allen
Copy link
Collaborator

@tim-p-allen tim-p-allen commented Dec 13, 2024 •
edited by tamirkamara
Loading

What is being addressed

aiohttp has been updated to 3.11.10 to fix 2 security issues that are fixed in this version.
https://github.com/microsoft/AzureTRE/security/dependabot/148
https://github.com/microsoft/AzureTRE/security/dependabot/138

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

Unit Test Results

596 tests   596 ✅  6s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 2bb4843.

♻️ This comment has been updated with latest results.

@tim-p-allen
Copy link
Collaborator Author

/test

@github-actions GitHub Actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12319979433 (with refid 66686dee)

(in response to this comment from @tim-allen-ck)

1 similar comment
@github-actions GitHub Actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12319979433 (with refid 66686dee)

(in response to this comment from @tim-allen-ck)

@tim-p-allen
Copy link
Collaborator Author

/test-extended

@github-actions GitHub Actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12323818465 (with refid 66686dee)

(in response to this comment from @tim-allen-ck)

@tim-p-allen
Copy link
Collaborator Author

/test

@github-actions GitHub Actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12349980276 (with refid 66686dee)

(in response to this comment from @tim-allen-ck)

@tim-p-allen tim-p-allen marked this pull request as ready for review December 16, 2024 13:09
@tim-p-allen tim-p-allen requested review from marrobi and tamirkamara and removed request for marrobi December 16, 2024 13:09
@tim-p-allen
Copy link
Collaborator Author

/test-extended

@tim-p-allen tim-p-allen enabled auto-merge (squash) December 16, 2024 16:05
@github-actions GitHub Actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12356562446 (with refid 66686dee)

(in response to this comment from @tim-allen-ck)

1 similar comment
@github-actions GitHub Actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12356562446 (with refid 66686dee)

(in response to this comment from @tim-allen-ck)

marrobi
marrobi approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marrobi
Copy link
Member

marrobi commented Dec 17, 2024

@tim-allen-ck got issues with results being reported again? Have any succeeded?

@tim-p-allen
Copy link
Collaborator Author

tim-p-allen commented Dec 17, 2024 •
edited
Loading

Yeah got one to pass all the way through
Weird

@tim-p-allen
Copy link
Collaborator Author

/test-force-approve

@github-actions GitHub Actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 93cd7f5)

(in response to this comment from @tim-allen-ck)

@tim-p-allen
Copy link
Collaborator Author

/test-force-approve

@github-actions GitHub Actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 2bb4843)

(in response to this comment from @tim-allen-ck)

@tim-p-allen tim-p-allen merged commit 5e857f6 into microsoft:main Dec 18, 2024
12 checks passed
@tim-p-allen tim-p-allen deleted the aiohttp_fix branch December 18, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marrobi marrobi marrobi approved these changes

@tamirkamara tamirkamara tamirkamara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tim-p-allen @marrobi @tamirkamara @tp-allen