Guacamole is accessible via public network

[tamirkamara]

PR for issue #705

What is being addressed

Guacamole is currently accessible via the private network which is not suitable for most use cases.

How is this addressed

• Add a parameter that allows Guacamole to be provisioned with/out public network access by enable/disable its private endpoint.

[github-actions]

Unit Test Results

  1 files  ±0    1 suites  ±0   7m 21s ⏱️ ±0s
11 tests ±0  11 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c9f2dbf. ± Comparison against base commit c9f2dbf.

♻️ This comment has been updated with latest results.

[marrobi]

LGTM - I'm not 100% sure on the variable naming and default. For example should the user have to tick a box to expose externally for example. We can always sort that later if feel its the wrong way round.

[tamirkamara]

@marrobi what here makes it harder to include a checkbox for the user to choose? The default?
Do you another name for the param?

[marrobi]

@tamirkamara I guess its the default - naming is controlled by the json schema.

By default it should probably be internal (thinking more of other services) as that is the most secure. A user then should take positive action to "expose the service externally". Maybe is_exposed_externally with a default of false is better. Not a big deal at the moment.