-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2293 add page for upgrade tags #2301
Merged
JesperSchulz
merged 7 commits into
microsoft:main
from
Bertverbeek4PS:2293-Add-page-for-upgrade-tags
Nov 18, 2024
Merged
2293 add page for upgrade tags #2301
JesperSchulz
merged 7 commits into
microsoft:main
from
Bertverbeek4PS:2293-Add-page-for-upgrade-tags
Nov 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
AL: System Application
From Fork
Pull request is coming from a fork
Linked
Issue is linked to a Azure Boards work item
labels
Nov 4, 2024
pri-kise
suggested changes
Nov 4, 2024
src/System Application/App/Upgrade Tags/src/UpgradeTags.Page.al
Outdated
Show resolved
Hide resolved
src/System Application/App/Upgrade Tags/src/UpgradeTags.Page.al
Outdated
Show resolved
Hide resolved
@nikolakukrika, could you give this a review? |
…Upgrade Tags table
nikolakukrika
requested changes
Nov 14, 2024
Awesome, thanks for doing this, please just add the Extensible false to the page. |
…ip and Extensible to false
JesperSchulz
requested changes
Nov 15, 2024
src/System Application/App/Upgrade Tags/src/UpgradeTags.Page.al
Outdated
Show resolved
Hide resolved
JesperSchulz
previously approved these changes
Nov 15, 2024
nikolakukrika
previously approved these changes
Nov 15, 2024
src/System Application/App/Upgrade Tags/src/UpgradeTags.Page.al
Outdated
Show resolved
Hide resolved
JesperSchulz
dismissed stale reviews from nikolakukrika and themself
via
November 15, 2024 11:57
e530c32
JesperSchulz
approved these changes
Nov 15, 2024
nikolakukrika
approved these changes
Nov 15, 2024
thanks @JesperSchulz and @nikolakukrika !! |
Thank YOU for this great contribution 🥳 |
Bertverbeek4PS
added a commit
to Bertverbeek4PS/BCApps
that referenced
this pull request
Nov 29, 2024
#### Summary It would be very welcome to add a page to the upgrade tags table so in that case you can see what kind of upgrade tags there are executed for troubleshooting. #### Work Item(s) Fixes microsoft#2293 Fixes [AB#556569](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/556569) --------- Co-authored-by: Jesper Schulz-Wedde <[email protected]> Co-authored-by: Jesper Schulz-Wedde <[email protected]>
JesperSchulz
added a commit
that referenced
this pull request
Nov 29, 2024
#### Summary It would be very welcome to add a page to the upgrade tags table so in that case you can see what kind of upgrade tags there are executed for troubleshooting. #### Work Item(s) Fixes #2417 Fixes [AB#556569](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/556569) --------- <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes # --------- Co-authored-by: Jesper Schulz-Wedde <[email protected]> Co-authored-by: Jesper Schulz-Wedde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
AL: System Application
From Fork
Pull request is coming from a fork
Integration
GitHub request for Integration area
Linked
Issue is linked to a Azure Boards work item
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It would be very welcome to add a page to the upgrade tags table so in that case you can see what kind of upgrade tags there are executed for troubleshooting.
Work Item(s)
Fixes #2293
Fixes AB#556569