No. Series: Ability to extend filters on finding No. Series Lines when getting new numbers

[PeterDurrer]

Summary

Add Event for No. Series

Work Item(s)

Fixes #1362

Fixes AB#558102

[PeterDurrer]

@PeterDurrer please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

• (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

• (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Logico Solutions AG"

[AndreasMoth]

Looks good, just need the other event to call the new GetNoSeriesLineFilters procedure as well.

[PeterDurrer]

@grobyns and @AndreasMoth There was some feedback and I have now tried to implement it accordingly. Please check the code again, thank you very much for this intensive review.
@dominicstarkl can you check whether these adjustments provide you with the required code sections that you wanted in issue #1362

[PeterDurrer]

@PeterDurrer please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

• (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

• (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Logico Solutions AG"

[PeterDurrer]

Dear @JesperSchulz , where can I find out from which BC version this will be available? I saw that 26.0 was set under milestones, but that will still be quite a while away. How do I find out whether this will be available in the next CU?

[JesperSchulz]

Dear @JesperSchulz , where can I find out from which BC version this will be available? I saw that 26.0 was set under milestones, but that will still be quite a while away. How do I find out whether this will be available in the next CU?

By default, the next release "vehicle" is the upcoming major - which in this case is 26.0. Upon request we happily backport for release with the upcoming minor though! I will set things in motion right away 😊

Expected release will then be 25.2.

[dominicstarkl]

@PeterDurrer @grobyns @AndreasMoth Thanks for your great implementation of this extensibility request - it fully meets our customers requirements 👍

Would it be possible to change this procedure from local to public?

• Codeunit 305 "No. Series - Setup Impl.", SetNoSeriesCurrentLineFilters()

It would help us to invoke the already public procedure DrillDown() without automatically running the no. series page.
We want to let the user choose from a no. series entry (LookupMode).
If this procedure would be public we could avoid code copying.

Thanks in advance for your appreciated reply!

Regards
Dominic

[grobyns]

@dominicstarkl I don't quite understand what you're trying to do. Also, the drilldown method you point to is not public, it's internal.

[dominicstarkl]

@grobyns
Hi Gert

As far as I can see there is no access modifier in procedure DrillDown. Could you show me your source code?

We want to select a No. Series Line from the possible No. Series Lines that show when you drill down from setup..
In DrillDown procedure we cannot specify the page behavior. We need to set LookUp mode to a page variable and run the page in our own.

Of course we could copy the code but it would be more future proof when this procedure was public and not local as it is right now.
As I can see this could be done without any interferences.

What do you think about it?

Regards
Dominic

[dominicstarkl]

@grobyns Now I have just seen that this whole Codeunit is internal. So we should place the public access somewhere else.

[grobyns]

@dominicstarkl I will take a look at the ask. I'm not convinced it will work as you expect.

Regardless, you should open a new issue for this. This pull request is closed and we'll need a new issue to handle this follow up case.

[dominicstarkl]

@grobyns Thanks Gert, I'll have a look at it