Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link for Delete Bot in Action Menu does not initiate the modal #6131

Closed
2 of 8 tasks
Dewain27 opened this issue Mar 3, 2021 · 2 comments · Fixed by #6366
Closed
2 of 8 tasks

Link for Delete Bot in Action Menu does not initiate the modal #6131

Dewain27 opened this issue Mar 3, 2021 · 2 comments · Fixed by #6366
Assignees
@benbrown @emivers8
Labels
P0 Must Fix. Release-blocker R12 Bugbash topic: creation Type: Bug Something isn't working
Milestone
R13

Comments

@Dewain27
Copy link
Contributor

Dewain27 commented Mar 3, 2021 •
edited
Loading

Describe the bug

Currently, the link for Delete Bot in the Action Menu in Bot Settings does not launch the delete modal.

Version

image

Browser

  • Electron distribution
  • Chrome
  • Safari
  • Firefox
  • Edge

OS

  • macOS
  • Windows
  • Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. Go to Bot Settings
  2. Click on Delete Bot in the Action Bar
  3. Needs to launch modal for delete, not scroll to the delete button below

Expected behavior

Clicking on the delete bot button should launch this modal
image

Additional context

The design of the modal for delete should be updated to proper design as well.
@Dewain27 Dewain27 added Type: Bug Something isn't working Needs-triage A new issue that require triage labels Mar 3, 2021
@Dewain27
Copy link
Contributor Author

Dewain27 commented Mar 3, 2021

@emivers8 has asked that the modal look and behave this way as well...
image

@emivers8
Copy link

emivers8 commented Mar 3, 2021

And actually, missed just a bit of copy on my first pass--

image

@cwhitten cwhitten removed the Needs-triage A new issue that require triage label Mar 7, 2021
@Dewain27 Dewain27 added this to the R13 milestone Mar 9, 2021
@Dewain27 Dewain27 added the P0 Must Fix. Release-blocker label Mar 9, 2021
@benbrown benbrown mentioned this issue Mar 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benbrown benbrown

@emivers8 emivers8

Labels
P0 Must Fix. Release-blocker R12 Bugbash topic: creation Type: Bug Something isn't working
Projects
None yet
Milestone
R13
Development

Successfully merging a pull request may close this issue.

fix: call shared deletebot modal from toolbar microsoft/BotFramework-Composer
4 participants
@benbrown @cwhitten @Dewain27 @emivers8