fix: call shared deletebot modal from toolbar #6366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbrown
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
a-b-r-o-w-n
previously approved these changes
Mar 16, 2021
Composer/packages/client/src/pages/botProject/DeleteBotButton.tsx
Outdated
Show resolved
Hide resolved
a-b-r-o-w-n
previously approved these changes
Mar 16, 2021
|
@benbrown there are some type checks that fail currently. |
hatpick
approved these changes
Mar 19, 2021
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* call shared deletebot modal from toolbar * adjust padding on modal * fix typos * remove unused items Co-authored-by: Andy Brown <[email protected]> Co-authored-by: Soroush <[email protected]> Co-authored-by: Chris Whitten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Open a revised Delete Bot modal from the toolbar directly instead of scrolling to the delete bot section of the settings page.
Task Item
fixes #6131
Screenshots
new modal:
behavior in place:
