build: make docker great again #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows us to save docker state across builds
a-b-r-o-w-n
requested review from
boydc2014,
cwhitten and
luhan2017
as code owners
cwhitten
approved these changes
Dec 6, 2019
|
MDGA! |
1 task
|
Hey @a-b-r-o-w-n, looks like i left comments in the previous PR #1708 (comment) It fails on my side to create bot from templates in docker run. Can you double-check on you side? @liweitian looks like it's related to templateId, can you also help verify on your side? |
|
@boydc2014 @a-b-r-o-w-n runtimeFolder: Path.resolve('../../../BotProject/Templates'), in docker the runtimeFolder is app/BotProject/Template. But the folder 'Botproject' was copied to / |
|
@boydc2014 @liweitian I will check on this today. Thanks for taking a look! |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1669