-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve the loading bot performance #5853
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boydc2014
previously approved these changes
Mar 23, 2021
boydc2014
approved these changes
Mar 29, 2021
Tested on my side, looks good! |
8 tasks
Merged
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* fix: loadBot will do full index twice * move lg parse background * add loading ui for single index * fix unit tests * fix unit tests * split the lg and qna state * add lu and qna to this solution * update set order * update lu lsp with worker * udpate the lint * udpate the worker * add await for async * update the lsp function * remove settimeout * refactor creating folding range in LG and LU * add unit tests * fix comments * fix some comments * fix comments and add unit tests * fix unit tests * update lu and qna * update the comparator * fix conflict * fix conflict Co-authored-by: Chris Whitten <[email protected]> Co-authored-by: Shuai Wang <[email protected]> Co-authored-by: Andy Brown <[email protected]> Co-authored-by: Srinaath Ravichandran <[email protected]> Co-authored-by: Ben Yackley <[email protected]> Co-authored-by: Dong Lei <[email protected]> Co-authored-by: Soroush <[email protected]> Co-authored-by: cosmicshuai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
issue
for calendar skill, parsing time is 19s, some other tasks' (render, state set) time is 3s, the total time to finish is 22s
![image](https://user-images.githubusercontent.com/39758135/108589780-0cfd8b00-739b-11eb-8981-06e92230bb72.png)
fix
The total time now to show the design page is about 5s
![image](https://user-images.githubusercontent.com/39758135/108590091-abd6b700-739c-11eb-9075-de8793ddc000.png)
next step
If this solution is ok, we can let lu and qna use the same solution during loading.
Task Item
refs #5708
Screenshots