Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve the loading bot performance #5853

Merged
merged 66 commits into from
Mar 29, 2021
Merged

Conversation

lei9444
Copy link
Contributor

@lei9444 lei9444 commented Feb 20, 2021

Description

issue

  1. The lg files are parsed twice
  2. composer will wait for all resources process to finish

for calendar skill, parsing time is 19s, some other tasks' (render, state set) time is 3s, the total time to finish is 22s
image

fix

  1. reduce one lg files' index. move all parsing operations to the worker.
  2. put the lg files index to background. If we open a new dialog, check the lg file state and do a single parse if the file is not yet parsed during the loading stage.

The total time now to show the design page is about 5s
image

next step
If this solution is ok, we can let lu and qna use the same solution during loading.

Task Item

refs #5708

Screenshots

loadtime

@boydc2014 boydc2014 added the 1.4 label Feb 24, 2021
@srinaath srinaath added this to the R12 milestone Feb 24, 2021
@coveralls
Copy link

coveralls commented Feb 25, 2021

Coverage Status

Coverage increased (+0.1%) to 52.908% when pulling 3d6f212 on lei9444:loadtime into c68205a on microsoft:main.

@lei9444 lei9444 marked this pull request as ready for review March 2, 2021 13:23
@boydc2014 boydc2014 removed this from the R12 milestone Mar 23, 2021
boydc2014
boydc2014 previously approved these changes Mar 23, 2021
@zhixzhan
Copy link
Contributor

Tested on my side, looks good!

@boydc2014 boydc2014 merged commit 5417fb1 into microsoft:main Mar 29, 2021
@hibrenda hibrenda mentioned this pull request Apr 6, 2021
8 tasks
@cwhitten cwhitten mentioned this pull request May 20, 2021
lei9444 added a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* fix: loadBot will do full index twice

* move lg parse background

* add loading ui for single index

* fix unit tests

* fix unit tests

* split the lg and qna state

* add lu and qna to this solution

* update set order

* update lu lsp with worker

* udpate the lint

* udpate the worker

* add await for async

* update the lsp function

* remove settimeout

* refactor creating folding range in LG and LU

* add unit tests

* fix comments

* fix some comments

* fix comments and add unit tests

* fix unit tests

* update lu and qna

* update the comparator

* fix conflict

* fix conflict

Co-authored-by: Chris Whitten <[email protected]>
Co-authored-by: Shuai Wang <[email protected]>
Co-authored-by: Andy Brown <[email protected]>
Co-authored-by: Srinaath Ravichandran <[email protected]>
Co-authored-by: Ben Yackley <[email protected]>
Co-authored-by: Dong Lei <[email protected]>
Co-authored-by: Soroush <[email protected]>
Co-authored-by: cosmicshuai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants