feature: Separated Add Resources to checklist #6386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hatpick
reviewed
Mar 12, 2021
extensions/azurePublish/src/components/azureProvisionDialog.tsx
Outdated
Show resolved
Hide resolved
extensions/azurePublish/src/components/azureProvisionDialog.tsx
Outdated
Show resolved
Hide resolved
extensions/azurePublish/src/components/azureProvisionDialog.tsx
Outdated
Show resolved
Hide resolved
GeoffCoxMSFT
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
GeoffCoxMSFT
changed the title
hatpick
previously approved these changes
Mar 18, 2021
benbrown
previously approved these changes
Mar 18, 2021
There was a problem hiding this comment.
Code looks awesome.
Small changes requested:
- Default optional to on. This is the current behavior we should preserve til we can discuss with PMs.
- Hide the required header if the required list is empty.
- Verify we didn't regress "edit" scenario where there are no remaining resources available (should jump to JSON view)
- Allow design to take a look and give final comments
…rosoft/BotFramework-Composer into gcox/provision-add-resources
|
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Separated Add Resources to checklist * Small PR fixes * Missed on find to includes change * Handling unmount in async useEffect and timeouts * Of course useRef * Updating to check all optional by default * Don't show section headers when empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AddResources step of details page used DetailsList which had interaction problems with required resources (not displaying checkboxes) and with readability/layout.
This replaces that step with a checklist style to solve the missing checkbox problem and improve the experience.
Task Item
fixes #6299 (fixed by removing DetailsList)
fixes #6095
Screenshots