Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added gray Composer icon to 'no triggers' dialog state #6414

Merged
merged 2 commits into from
Mar 15, 2021

Conversation

tonyanziano
Copy link
Contributor

Description

Adds a gray Composer icon to the flow editor when a selected dialog has no triggers

Task Item

Fixes #6377

Screenshots

BEFORE:

trigger-landing-before

AFTER:

trigger-landing-after

@coveralls
Copy link

coveralls commented Mar 15, 2021

Coverage Status

Coverage remained the same at 52.98% when pulling 9e0adf3 on toanzian/trigger-logo into e52a61e on main.

@beyackle beyackle merged commit b8bc0e0 into main Mar 15, 2021
@beyackle beyackle deleted the toanzian/trigger-logo branch March 15, 2021 18:50
cwhitten pushed a commit that referenced this pull request Mar 15, 2021
cwhitten added a commit that referenced this pull request Mar 23, 2021
* release: 1.4.0-rc0

* fix: lg create error with multi-language (#6412)

Co-authored-by: Ben Yackley <[email protected]>

* fix: Remove Attachment Lg template when they are deleted in the Response Editor (#6405)

* fix: Remove Attachment Lg template when they are deleted in the Response Editor

* strings

Co-authored-by: Soroush <[email protected]>

* 1.4.0-rc1

* Added gray Composer icon to 'no triggers' dialog state (#6414)

Co-authored-by: Ben Yackley <[email protected]>

* Get an ARM token only when publishing to Azure (#6418)

Co-authored-by: Chris Whitten <[email protected]>

* fix: composer doesn't see component dialogs that are in subfolders (#6420)

* fix: composer doesn't see component dialogs that are in subfolders

* clean unused code

* fix: revert yeoman-environment to 2.10.3 from 3.1.0 (#6415)

* 1.4.0-rc2

* fix: load feature flags if default keys have changed (#6432)

* handle case when default feature flags change

If a feature flag is renamed or removed, Composer would fail when updating feature flags.

* show app error when feature flags fail to fetch in development

Co-authored-by: Chris Whitten <[email protected]>

* fix: use new create flow during add skill if enabled (#6427)

* Initial changes for component model add skills flow

* Reusing function

* Add new bot as skill working e2e in component model creation

* cleaning up PR

* removing unused imports

* - fixing typos
- enabling qna template to be instantiated as a skill

* Fixing title in addSkills modal and fixing default template

* fix useEffect

Co-authored-by: Patrick Volum <[email protected]>

* Update bf-orchestrator to 4.12.0-beta.20210316.cdd0819 (#6435)

Co-authored-by: Chris Whitten <[email protected]>

* fix: make CSS show triangles in project tree (#6428)

Co-authored-by: Andy Brown <[email protected]>

* feat: Implement layout to errorCallout (#6396)

* implement layout to errorCallout

* Fix linting issues

Co-authored-by: Andy Brown <[email protected]>

* fis: change feature flag text (#6438)

Co-authored-by: Patrick Volum <[email protected]>

* feat: update runtime package to 4.12.1 (#6441)

* Update to 4.12.1

* update schema

Co-authored-by: Lu Han <[email protected]>

* fix: hidden showCode button when url is all & show code for form dialog (#6444)

* hidden showCode button when dialog is all & show code for form dialog

* ci fix

* lint

Co-authored-by: Dong Lei <[email protected]>

* Fixing projectId state by ordering state change (#6437)

Co-authored-by: Patrick Volum <[email protected]>

* prepare changelog for 1.4.0

* 1.4.0-rc3

* feat: take 4.12.2 runtime package (#6469)

* take 4.12.2

* Update schema

Co-authored-by: Lu Han <[email protected]>

* fix: Allow multiline variations for LG text and speech modalities (#6394)

* fix: Allow multiline variations for LG text and speech modalities

* fix tests

* pr comment

Co-authored-by: Soroush <[email protected]>

* fix actions (#6476)

Co-authored-by: Soroush <[email protected]>

* release: 1.4.0

* Update 1.4.0.md

* RC4

* Update bf-orchestrator to 4.12.0-beta.20210322.314475a (#6496)

Co-authored-by: Chris Whitten <[email protected]>
Co-authored-by: leileizhang <[email protected]>
Co-authored-by: Ben Yackley <[email protected]>
Co-authored-by: TJ Durnford <[email protected]>
Co-authored-by: Soroush <[email protected]>
Co-authored-by: Chris Whitten <[email protected]>
Co-authored-by: Ben Brown <[email protected]>
Co-authored-by: Andy Brown <[email protected]>
Co-authored-by: pavolum <[email protected]>
Co-authored-by: Patrick Volum <[email protected]>
Co-authored-by: taicchoumsft <[email protected]>
Co-authored-by: Christiano Donke <[email protected]>
Co-authored-by: Dong Lei <[email protected]>
Co-authored-by: Lu Han <[email protected]>
Co-authored-by: Long Alan <[email protected]>
Co-authored-by: Soroush <[email protected]>
@cwhitten cwhitten mentioned this pull request May 20, 2021
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
lei9444 added a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* release: 1.4.0-rc0

* fix: lg create error with multi-language (microsoft#6412)

Co-authored-by: Ben Yackley <[email protected]>

* fix: Remove Attachment Lg template when they are deleted in the Response Editor (microsoft#6405)

* fix: Remove Attachment Lg template when they are deleted in the Response Editor

* strings

Co-authored-by: Soroush <[email protected]>

* 1.4.0-rc1

* Added gray Composer icon to 'no triggers' dialog state (microsoft#6414)

Co-authored-by: Ben Yackley <[email protected]>

* Get an ARM token only when publishing to Azure (microsoft#6418)

Co-authored-by: Chris Whitten <[email protected]>

* fix: composer doesn't see component dialogs that are in subfolders (microsoft#6420)

* fix: composer doesn't see component dialogs that are in subfolders

* clean unused code

* fix: revert yeoman-environment to 2.10.3 from 3.1.0 (microsoft#6415)

* 1.4.0-rc2

* fix: load feature flags if default keys have changed (microsoft#6432)

* handle case when default feature flags change

If a feature flag is renamed or removed, Composer would fail when updating feature flags.

* show app error when feature flags fail to fetch in development

Co-authored-by: Chris Whitten <[email protected]>

* fix: use new create flow during add skill if enabled (microsoft#6427)

* Initial changes for component model add skills flow

* Reusing function

* Add new bot as skill working e2e in component model creation

* cleaning up PR

* removing unused imports

* - fixing typos
- enabling qna template to be instantiated as a skill

* Fixing title in addSkills modal and fixing default template

* fix useEffect

Co-authored-by: Patrick Volum <[email protected]>

* Update bf-orchestrator to 4.12.0-beta.20210316.cdd0819 (microsoft#6435)

Co-authored-by: Chris Whitten <[email protected]>

* fix: make CSS show triangles in project tree (microsoft#6428)

Co-authored-by: Andy Brown <[email protected]>

* feat: Implement layout to errorCallout (microsoft#6396)

* implement layout to errorCallout

* Fix linting issues

Co-authored-by: Andy Brown <[email protected]>

* fis: change feature flag text (microsoft#6438)

Co-authored-by: Patrick Volum <[email protected]>

* feat: update runtime package to 4.12.1 (microsoft#6441)

* Update to 4.12.1

* update schema

Co-authored-by: Lu Han <[email protected]>

* fix: hidden showCode button when url is all & show code for form dialog (microsoft#6444)

* hidden showCode button when dialog is all & show code for form dialog

* ci fix

* lint

Co-authored-by: Dong Lei <[email protected]>

* Fixing projectId state by ordering state change (microsoft#6437)

Co-authored-by: Patrick Volum <[email protected]>

* prepare changelog for 1.4.0

* 1.4.0-rc3

* feat: take 4.12.2 runtime package (microsoft#6469)

* take 4.12.2

* Update schema

Co-authored-by: Lu Han <[email protected]>

* fix: Allow multiline variations for LG text and speech modalities (microsoft#6394)

* fix: Allow multiline variations for LG text and speech modalities

* fix tests

* pr comment

Co-authored-by: Soroush <[email protected]>

* fix actions (microsoft#6476)

Co-authored-by: Soroush <[email protected]>

* release: 1.4.0

* Update 1.4.0.md

* RC4

* Update bf-orchestrator to 4.12.0-beta.20210322.314475a (microsoft#6496)

Co-authored-by: Chris Whitten <[email protected]>
Co-authored-by: leileizhang <[email protected]>
Co-authored-by: Ben Yackley <[email protected]>
Co-authored-by: TJ Durnford <[email protected]>
Co-authored-by: Soroush <[email protected]>
Co-authored-by: Chris Whitten <[email protected]>
Co-authored-by: Ben Brown <[email protected]>
Co-authored-by: Andy Brown <[email protected]>
Co-authored-by: pavolum <[email protected]>
Co-authored-by: Patrick Volum <[email protected]>
Co-authored-by: taicchoumsft <[email protected]>
Co-authored-by: Christiano Donke <[email protected]>
Co-authored-by: Dong Lei <[email protected]>
Co-authored-by: Lu Han <[email protected]>
Co-authored-by: Long Alan <[email protected]>
Co-authored-by: Soroush <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.4 PVA issues
4 participants