fix: Added retry logic to OneAuth login flows when an interactive sign in is required

[tonyanziano]

Description

There was retry logic for the OneAuth getAccessToken() flow, but it was trying to catch the InteractionRequired error in the wrong place. A login error actually throws, which ends up in the catch block.

Moved retry logic to the catch block, and also added it to the ARM login flow.

Task Item

This potentially fixes the issue we were seeing with Non-federated accounts:

Fixes #5436

[coveralls]

Coverage increased (+0.02%) to 52.792% when pulling 7cc7d85 on toanzian/login-retry into 3afb128 on main.

[ehsan2018]

Hello, I am having a similar issue upon publishing a bot from composer V1.4.
As soon as I sign in with my Azure credential I receive an error. Would you please provide a plain language instruction as I am not a developer and have a hard time following technical terms. Thank you.

[a-b-r-o-w-n]

hi @ehsan2018, could you try updating to the nightly version of Composer? We have been investing in this area and some improvements have been made that are not yet released.

To do so, go to the settings page and check the box for early adopters in the application updates section. Then go to Help > Check for updates to get the latest.

With that being said, we are still working through some authentication issues, especially for users that are in multiple azure tenants, but hopefully you will be unblocked by using the latest version.

[ehsan2018]

Thank you for your quick reply. I do not see the 'early adopters' under the setting page. However, it seems my application is up to date as I clicked on help/ check for update (please see below). Also, I am currently using a free subscription. Thank you.

[a-b-r-o-w-n]

@ehsan2018 check on the application settings page (the gear icon on the bottom left).