Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refocus locale dropdown after load #6495

Merged
merged 7 commits into from
Mar 30, 2021
Merged

Conversation

beyackle
Copy link
Contributor

Description

This refocuses the language dropdown after the app changes locale. Changing the locale causes the page to refresh, so we need to manually set the focus back to where it was.

Task Item

closes #6459

Screenshots

These screenshots are before and after hitting the "up" button to move from Swedish to Russian.

image
image

@beyackle beyackle changed the title refocus locale dropdown after load fix: refocus locale dropdown after load Mar 22, 2021
@coveralls
Copy link

coveralls commented Mar 25, 2021

Coverage Status

Coverage decreased (-0.006%) to 51.99% when pulling 7562ae4 on beyackle/focusAfterLoad into da1ac55 on main.

@cwhitten cwhitten merged commit 841a17e into main Mar 30, 2021
@cwhitten cwhitten deleted the beyackle/focusAfterLoad branch March 30, 2021 01:55
@cwhitten cwhitten mentioned this pull request May 20, 2021
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KB: language dropdown loses focus on change
3 participants