Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor create options modal for abs #6517

Merged
merged 6 commits into from
Mar 24, 2021

Conversation

alanlong9278
Copy link
Contributor

Description

Refactor createOptions modal for abs depends on new design. https://www.figma.com/file/DxN7GOTds0xII7Hp1zeYjtuW/ABS-main?node-id=1888%3A963
image

Old scenario

  • alias data have value
    • jump to bot design page straight
  • alias data empty
    • open create new bot modal

New scenario

  • alias data have value
    • open choice modal to choose if open exist bot or create new bot

abs

  • alias data empty
    • open create new bot modal

Task Item

#minor

Screenshots

@coveralls
Copy link

coveralls commented Mar 23, 2021

Coverage Status

Coverage increased (+0.002%) to 52.733% when pulling 352b1af on julong/abs-createOptions-modal into 4dd99f4 on main.

tonyanziano
tonyanziano previously approved these changes Mar 24, 2021
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks pretty good to me!

@luhan2017 luhan2017 merged commit 4a08f6a into main Mar 24, 2021
@luhan2017 luhan2017 deleted the julong/abs-createOptions-modal branch March 24, 2021 06:38
@cwhitten cwhitten mentioned this pull request May 20, 2021
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* refactor create option modal

* test

* lint

* rename isOpen to isOpenOptionsModal

Co-authored-by: Lu Han <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants