-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Warm up Orchestrator build cache from previous Composer session #6550
Conversation
); | ||
|
||
return modelData.model && snapshotData.length | ||
? await Orchestrator.getLabelResolversAsync(modelData.model, '', new Map(snapshotData), false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this matches the lu object id "f.replace('.blu', '.lu')" pass in the buildAsync method, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, these are also the ids we get back from the results object from buildAsync
,
…microsoft/BotFramework-Composer into tachou/orchColdBootOptimization
By code session, we mean, maybe it was closed before, right? If for a hot session, we will just memorize that in memory, is that correct? |
Yes, that is right. This cache warmup is only for when user has trained Orchestrator in a previous session, then closed Composer, then re-opened it. If the user is in the same hot session, we use the existing in-memory cache logic. |
Tested it and LGTM |
…icrosoft#6550) * Update orch package * initial implementation * Tighten up code and exception handling * Unit tests * Fix linter errors * Don't rethrow error for cache - safe to continue on * Fix build error of worker script when testing Co-authored-by: Dong Lei <[email protected]>
Description
If there are embeddings (in
.blu
files) from a previous Composer session, we can use them to warm up the OrchestratorLabelResolversCache
. This dramatically speeds up subsequent build times in a cold Composer session.If Orchestrator isn't used, the warmup does nothing.
Task Item
closes #6481