Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Homepage new design, news feed #6642

Merged
merged 27 commits into from
Apr 7, 2021
Merged

Conversation

zhixzhan
Copy link
Contributor

@zhixzhan zhixzhan commented Apr 1, 2021

Description

Homepage new design, news feed fetch from GitHub.

Task Item

refs #5857

Screenshots

2021-04-01 16 54 50

@zhixzhan zhixzhan requested a review from garypretty April 1, 2021 08:58
@coveralls
Copy link

coveralls commented Apr 1, 2021

Coverage Status

Coverage decreased (-0.02%) to 51.634% when pulling 29de833 on zhixzhan/homepage-refine into 7c9e1ec on main.

@zhixzhan zhixzhan marked this pull request as ready for review April 2, 2021 06:31
@srinaath
Copy link
Contributor

srinaath commented Apr 2, 2021

@zhixzhan Have you tested this PR on an electron installer just to make sure things are rendering OK?

@zhixzhan
Copy link
Contributor Author

zhixzhan commented Apr 6, 2021

@zhixzhan Have you tested this PR on an electron installer just to make sure things are rendering OK?

@srinaath Verified, rendering as expected.

@zhixzhan zhixzhan force-pushed the zhixzhan/homepage-refine branch from 4553ab2 to b4f2cf8 Compare April 7, 2021 01:17
@boydc2014 boydc2014 merged commit 0d7feaa into main Apr 7, 2021
@boydc2014 boydc2014 deleted the zhixzhan/homepage-refine branch April 7, 2021 11:23
@cwhitten cwhitten mentioned this pull request May 20, 2021
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* new design in homepage

* update

* update

* add feeds

* feed server api

* update

* fix when fetch error

* update tests

* update styles

* add tests

* verify feed version

* no border line above empty box

* fetch feed once.

* update styles

* update

* handle aka.ms redirect

* update feed url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants