Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes pre-commit hook for extensions #6655

Merged
merged 5 commits into from
Apr 2, 2021
Merged

fix: fixes pre-commit hook for extensions #6655

merged 5 commits into from
Apr 2, 2021

Conversation

hatpick
Copy link
Contributor

@hatpick hatpick commented Apr 2, 2021

Description

fixes pre-commit hook for extensions

Task Item

#minor

@coveralls
Copy link

coveralls commented Apr 2, 2021

Coverage Status

Coverage remained the same at 51.389% when pulling 78d6218 on sorgh/fix_prettier into 99d7e4c on main.

@a-b-r-o-w-n
Copy link
Contributor

We'll want someone on Windows to test this. I recall there being some issues with the extensions glob plus the parent directory. @beyackle or @tonyanziano can you give this a whirl tomorrow?

beyackle
beyackle previously approved these changes Apr 2, 2021
Copy link
Contributor

@beyackle beyackle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this in Windows and it appears to be working as intended.

@hatpick hatpick merged commit 126bf83 into main Apr 2, 2021
@hatpick hatpick deleted the sorgh/fix_prettier branch April 2, 2021 17:30
@cwhitten cwhitten mentioned this pull request May 20, 2021
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* fix extensions prettier

* strings (fixes missing key)

Co-authored-by: Soroush <[email protected]>
Co-authored-by: Ben Yackley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants