feature: Added provision resource checks before publish #6662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cwhitten - I think this should fix the ABS 'Open in composer' scenario when trying to publish. |
hatpick
previously approved these changes
Apr 2, 2021
hatpick
reviewed
Apr 2, 2021
hatpick
approved these changes
Apr 2, 2021
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Added provision resource checks before publish * Remove unused import * Added return type for linter * changed to use reduce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before publishing, the publishing profile needs to be checked to verify that the provisioning occurred at least once successfully and that all required resources have values from successful provisioning.
To avoid blocking the user unnecessarily , the checks verify the minimum values exist and do not verify values that could be empty for some deployments.
Task Item
fixes #6627
Screenshots
N/A - verification errors are displayed through the standard notification and result messages