Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Added skill manifest URL to publish page #6665

Merged
merged 5 commits into from
Apr 3, 2021

Conversation

GeoffCoxMSFT
Copy link
Member

Description

This provides the basic link and copies the manifest URL to the clipboard.
A future PR will improve the copy experience to include a callout when copied via a more general purpose mechanism.

Task Item

closes #6597

Screenshots

image

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 51.368% when pulling e09aadb on gcox/feature6597 into 8b7ea1a on main.

name: '',
className: 'skillManifest',
fieldName: 'skillManifestUrl',
minWidth: 114,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

magic numbers 😄

@@ -321,6 +365,12 @@ export const BotStatusList: React.FC<BotStatusListProps> = ({
onRenderRow={renderTableRow}
/>
</div>
<TextField
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use a simple input since it's hidden instead of TextField component

@GeoffCoxMSFT GeoffCoxMSFT merged commit e5e5020 into main Apr 3, 2021
@GeoffCoxMSFT GeoffCoxMSFT deleted the gcox/feature6597 branch April 3, 2021 18:35
@cwhitten cwhitten mentioned this pull request May 20, 2021
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* Added first take at copying skill manifest URL

* Updated strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publishing page with skill manifest URL
3 participants