fix: Orchestrator worker crashes if accessing getLabelResolversAsync concurrently #6667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taicchoumsft
requested review from
a-b-r-o-w-n,
beyackle,
cwhitten and
GeoffCoxMSFT
as code owners
taicchoumsft
requested review from
hatpick,
srinaath and
tonyanziano
as code owners
hatpick
reviewed
Apr 5, 2021
Composer/packages/server/src/models/bot/process/orchestratorWorker.ts
Outdated
Show resolved
Hide resolved
Composer/packages/server/src/models/bot/process/orchestratorWorker.ts
Outdated
Show resolved
Hide resolved
hatpick
approved these changes
Apr 5, 2021
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…concurrently (microsoft#6667) Co-authored-by: Soroush <[email protected]> Co-authored-by: Dong Lei <[email protected]> Co-authored-by: Chris Whitten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
promise.allwhen callinggetLabelResolversAsync, it occasionally crashes the Orchestrator worker thread.Exceptions were also not forwarded correctly, when exceptions occurred during build or warmup of Orchestrator, the process never ends since we never send a message back to the main thread. It's also not possible to send the error object in raw form, the process boundary prevents this. So extract the
messageandstackproperty only and forward those.Task Item
fixes #6666