Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Made copying manifest url to clipboard better #6698

Merged
merged 10 commits into from
Apr 6, 2021
Merged

feature: Made copying manifest url to clipboard better #6698

merged 10 commits into from
Apr 6, 2021

Conversation

GeoffCoxMSFT
Copy link
Member

Description

This

  • provides a general purpose useCopyToClipboard hook in ui-shared.
  • breaks out the manifest URL copy into its own component so it can track state per instance
  • adds a copied callout to each time the URL is copied.

Task Item

fixes #6597

Screenshots

image

@GeoffCoxMSFT GeoffCoxMSFT requested a review from benbrown April 5, 2021 22:20
@GeoffCoxMSFT GeoffCoxMSFT requested a review from hatpick April 6, 2021 17:34
@coveralls
Copy link

coveralls commented Apr 6, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 51.691% when pulling 7c88470 on gcox/improve6597 into 80d4a1c on main.

@GeoffCoxMSFT GeoffCoxMSFT merged commit b2c336a into main Apr 6, 2021
@GeoffCoxMSFT GeoffCoxMSFT deleted the gcox/improve6597 branch April 6, 2021 21:51
@cwhitten cwhitten mentioned this pull request May 20, 2021
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@GeoffCoxMSFT @hatpick
feature: Made copying manifest url to clipboard better (microsoft#6698)
f667ae1 
* Made copying to clipboard better

* PR fixes

* CI fix

* Fix ref usage

Co-authored-by: Soroush <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hatpick hatpick hatpick approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@cwhitten cwhitten Awaiting requested review from cwhitten

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

@benbrown benbrown Awaiting requested review from benbrown

Assignees

@hatpick hatpick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publishing page with skill manifest URL
3 participants
@GeoffCoxMSFT @coveralls @hatpick