Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle protocol launches on macos from cold start #6738

Merged
merged 4 commits into from
Apr 7, 2021

Conversation

a-b-r-o-w-n
Copy link
Contributor

Description

Fixes an issue where deeplinks would not work correctly on mac when Composer was not already running.

Task Item

fixes #6616

@coveralls
Copy link

coveralls commented Apr 7, 2021

Coverage Status

Coverage increased (+0.006%) to 51.604% when pulling faf4f53 on abrown/mac-deeplink into 8bea594 on main.

@a-b-r-o-w-n
Copy link
Contributor Author

Testing this with an installer now. Launch from PVA was successful.

@a-b-r-o-w-n a-b-r-o-w-n marked this pull request as ready for review April 7, 2021 21:39
@cwhitten cwhitten merged commit f98e615 into main Apr 7, 2021
@cwhitten cwhitten deleted the abrown/mac-deeplink branch April 7, 2021 22:08
@cwhitten cwhitten mentioned this pull request May 20, 2021
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3/29 bugbash] Not able to open an Azure Bot in Composer
4 participants