fix: use shell: true on windows so cmd aliases work #6742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running a command on windows, `shell: true` must be used so `alias.cmd` can be just invoked as `alias`. This will ensure that template and generator authors do not need Windows-specific logic.
joshgummersall
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
|
Note: https://nodejs.org/api/child_process.html#child_process_default_windows_shell mentions some special considerations when invoking commands as a shell that can lead to arbitrary command execution. Technically, Composer already executes an arbitrary command for a particular runtime, so I'm not sure if this needs to be handled specially. |
joshgummersall
changed the title
GeoffCoxMSFT
approved these changes
Apr 8, 2021
benbrown
approved these changes
Apr 9, 2021
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
When running a command on windows, `shell: true` must be used so `alias.cmd` can be just invoked as `alias`. This will ensure that template and generator authors do not need Windows-specific logic. Co-authored-by: Ben Brown <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a command on windows,
shell: truemust be used soalias.cmdcan be just invoked asalias. This will ensure thattemplate and generator authors do not need Windows-specific logic.
#minor