Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Added connection string #6850

Merged
merged 6 commits into from
Apr 13, 2021
Merged

feature: Added connection string #6850

merged 6 commits into from
Apr 13, 2021

Conversation

GeoffCoxMSFT
Copy link
Member

@GeoffCoxMSFT GeoffCoxMSFT commented Apr 9, 2021

Description

Adds the connection string for app insights.

Task Item

Fixes #6843

Screenshots

N/A

@coveralls
Copy link

coveralls commented Apr 9, 2021

Coverage Status

Coverage decreased (-0.003%) to 51.108% when pulling 0fe58d7 on gcox/fix6842 into f98ff67 on main.

@benbrown benbrown assigned GeoffCoxMSFT and unassigned benbrown Apr 13, 2021
@GeoffCoxMSFT GeoffCoxMSFT marked this pull request as ready for review April 13, 2021 17:25
@GeoffCoxMSFT GeoffCoxMSFT changed the title Added connection string feature: Added connection string Apr 13, 2021
@GeoffCoxMSFT GeoffCoxMSFT merged commit 991edc8 into main Apr 13, 2021
@GeoffCoxMSFT GeoffCoxMSFT deleted the gcox/fix6842 branch April 13, 2021 21:04
@cwhitten cwhitten mentioned this pull request May 20, 2021
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* Added connection string

* fix microsoft#6843: apply new connectionstring to settings during publish

* Fix lint issue

Co-authored-by: Ben Brown <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust the applyPublishProfileToSEttings function to compensate for new appinsights key
4 participants