Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: QnA files multi-lang migration fix #6863

Merged
merged 9 commits into from
Apr 15, 2021
Merged

Conversation

zhixzhan
Copy link
Contributor

@zhixzhan zhixzhan commented Apr 12, 2021

Description

Fix QnA files multi-lang migration failed, and some regression introduced by lazy indexing

Task Item

#minor

Screenshots

@coveralls
Copy link

coveralls commented Apr 12, 2021

Coverage Status

Coverage increased (+0.006%) to 51.163% when pulling 50929a9 on zhixzhan/qna-migration-fix into 494d363 on main.

@liweitian
Copy link
Contributor

liweitian commented Apr 12, 2021

If we have two languages, add qna pairs in dialogName.en-us.qna, will only generate dialogName-manual.source.en-us.qna. You can only generate dialogName-manual.source.qna, it will be copied to other languages on the second step of qna file migration.

And every dialogName.{locale}.qna files need to import the dialogName-manual.source.{locale}.qna.

@zhixzhan
Copy link
Contributor Author

If we have two languages, add qna pairs in dialogName.en-us.qna, will only generate dialogName-manual.source.en-us.qna.
You can only generate dialogName-manual.source.qna, it will be copied to other languages on the second step of qna file migration.

@liweitian I think this is expected, because only in dialogName.en-us.qna have content to migrate, in other qna file dialogName.{locale}.qna there is nothing to migrate.

And every dialogName.{locale}.qna files need to import the dialogName-manual.source.{locale}.qna.

if there is not such file, there is no need to import it in every language.

@boydc2014 boydc2014 changed the title fix: QnA files multi-lang migration fix: QnA files multi-lang migration fix Apr 14, 2021
@cwhitten cwhitten merged commit b0e2d61 into main Apr 15, 2021
@cwhitten cwhitten deleted the zhixzhan/qna-migration-fix branch April 15, 2021 03:06
@cwhitten cwhitten mentioned this pull request May 20, 2021
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Co-authored-by: Ben Yackley <[email protected]>
Co-authored-by: Dong Lei <[email protected]>
Co-authored-by: Chris Whitten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants