fix: misc UI fixes around creation and config #6878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolum
requested review from
a-b-r-o-w-n,
benbrown,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
|
@benbrown it seems there is a bit of redundant code in the qnaModal and LuisModal components when they call azure to get the users available subscriptions. I also see that code was copied from the azurePublish extension. Do we have an item tracking a minor refactor? It would be ideal to have a shared workspace where we could put this function and have it used by the client workspace and AzurePublish extension that way it is written once and used in three seperate places as opposed to the current situation where we have the same logic written in three different places. |
|
@pavolum yes it is on the backlog to refactor these into a single shared component. |
beyackle
suggested changes
Apr 12, 2021
Composer/packages/client/src/components/ManageLuis/ManageLuis.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/ManageQNA/ManageQNA.tsx
Outdated
Show resolved
Hide resolved
…ft/BotFramework-Composer into pavolum/CreationUiFixes2
benbrown
approved these changes
Apr 13, 2021
srinaath
approved these changes
Apr 13, 2021
beyackle
approved these changes
Apr 13, 2021
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Removing yeoman from creation status messages * alphabetizing azure subscriptions and resource groups * Normalizing loading spinner UI on designer page to match modal UI for botOpening modal * Handle UI update when luis key is updates through luis modal * handle settings UI updates for external qna key update * removing unused imports and style variable * Ensure luis region UI is populated once set from modal * Adding alphabetic sorting to qna and luis modal * Fixing sorting logic to use lodash abstraction * Updating status messages Co-authored-by: Ben Yackley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains various fixes for UI bugs that were filed during initial bug bashing. More details below in the Task Item header.
Task Item
fix #6769 - Added sorting to api call results for getSubscription and getResourceGroups
fix #6815 - Removed 'yeoman' string from status messages
fix #6837 - There have always been two loading spinners in the open project flow, one for bot opening and one for design view loading. They were previously identical so the end user saw no visible change in the loading UI when running the bot opening flow. Since then the botOpening loading spinner UI was updated. This PR updates the design page spinner UI to match the updated bot opening so end users see the same loading UI for both spinners.
fix #6822 - in development