fix: adjust mechanism used to create qna host #6881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbrown
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
|
Please fix this issue is Composer.exe which is running on Windows as we are kind of stuck here. |
cwhitten
approved these changes
Apr 13, 2021
8 tasks
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* adjust mechanism used to create qna host * Update the QNA endpoint key when creating with new wizard * remove old code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous mechanism used to create the appservice config when provisioning a QNA maker was not successfully setting the configuration.
This PR changes the mechanism used, and verifiably sets these config options.
#minor
The issue:
prior to this PR, the QNA provisioning process would create an app service. However, the "application settings" necessary for that app service to perform its QNA features were not being set. They were not appearing in the azure portal, and qna publishing related actions returned an error:
Qnamaker build failed: No Endpoint keys found. If this is a new service, please wait a minimum of 10 minutes for the runtime to be ready.Using this version, the app service IS configured with these additional settings, and I am able to publish to QNA without receiving this error.