Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update text in handoff modals #6902

Merged
merged 3 commits into from
Apr 13, 2021
Merged

Conversation

benbrown
Copy link
Contributor

@benbrown benbrown commented Apr 13, 2021

Description

Adds the handoff instructions for LUIS, QNA, Speech and provision process.

Task Item

Fixes #6567
Fixes #6566
Fixes #6867

Screenshots

Screen Shot 2021-04-13 at 11 38 23 AM

Copy link
Contributor

@beyackle beyackle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from one teeny thing; everywhere else I've seen QnA, the n is lowercase.

@benbrown benbrown requested a review from beyackle April 13, 2021 19:47
@hatpick
Copy link
Contributor

hatpick commented Apr 13, 2021

Shouldn't the back button not be primary (not blue)? @benbrown

@benbrown benbrown merged commit f98ff67 into main Apr 13, 2021
@benbrown benbrown deleted the benbrown/handoffinstructions branch April 13, 2021 20:26
@coveralls
Copy link

coveralls commented Apr 13, 2021

Coverage Status

Coverage decreased (-0.01%) to 51.139% when pulling fdef5a8 on benbrown/handoffinstructions into b90b17b on main.

@cwhitten cwhitten mentioned this pull request May 20, 2021
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* update text in handoff modals

* fix casing of QnA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants