Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when add remote skill show manifest json parse error #7396

Merged
merged 12 commits into from
Apr 28, 2021
Merged

fix: when add remote skill show manifest json parse error #7396

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e575526
skill manifest show json parse error
zhixzhan Apr 27, 2021
cb33875
update
zhixzhan Apr 27, 2021
1b725a0
Merge branch 'main' into zhixzhan/skill-manifest-error
boydc2014 Apr 27, 2021
2a1914e
Merge branch 'main' into zhixzhan/skill-manifest-error
cwhitten Apr 27, 2021
11bf7e7
Update CreateSkillModal.tsx
cwhitten Apr 27, 2021
4fcdaef
Update CreateSkillModal.tsx
cwhitten Apr 27, 2021
e5e5558
Merge branch 'main' into zhixzhan/skill-manifest-error
cwhitten Apr 27, 2021
3309450
Merge branch 'main' into zhixzhan/skill-manifest-error
zhixzhan Apr 28, 2021
b8e3c31
update message
zhixzhan Apr 28, 2021
b75068d
Merge branch 'main' into zhixzhan/skill-manifest-error
boydc2014 Apr 28, 2021
c74a1a4
Merge branch 'main' into zhixzhan/skill-manifest-error
cwhitten Apr 28, 2021
6b64270
Merge branch 'main' into zhixzhan/skill-manifest-error
cwhitten Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Composer/packages/client/src/components/AddRemoteSkillModal/CreateSkillModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,12 @@ export const getSkillManifest = async (projectId: string, manifestUrl: string, s
});
setSkillManifest(data);
} catch (error) {
setFormDataErrors({ ...error, manifestUrl: formatMessage('Manifest URL can not be accessed') });
const httpMessage = error?.response?.data?.message;
const message = httpMessage?.match('Unexpected string in JSON')
? formatMessage("Error attempting to parse Skill manifest. There could be an error in it's format.")
: formatMessage('Manifest URL can not be accessed');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cwhitten , I made some update base on your change here . Is this your intention?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes thank you @zhixzhan !


setFormDataErrors({ ...error, manifestUrl: message });
}
};
const getTriggerFormData = (intent: string, content: string): TriggerFormData => ({
Expand Down