Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add role to User #79

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Add role to User #79

merged 1 commit into from
Aug 14, 2018

Conversation

compulim
Copy link
Collaborator

@compulim compulim commented Jul 22, 2018 •
edited
Loading

"role" is required for transcript in Emulator to work properly, and will enable multi-user scenario.

Currently, in User interface, we only have id, name, and iconUrl. They are not sufficient to clearly identify the origin of an activity. With the upcoming multi-user support, it will be more confusing between bot and users.

The newly added role will give a clearer sense on if the activity is from a bot or an user.

botbuilder-dotnet also has role defined in ChannelAccount.cs:68.

@compulim compulim requested a review from billba July 22, 2018 20:58
@compulim compulim mentioned this pull request Jul 22, 2018
Merged
@tonyanziano tonyanziano mentioned this pull request Jul 26, 2018
Closed
@compulim compulim requested review from sgellock, Stevenic and tomlm July 31, 2018 01:15
@compulim
Copy link
Collaborator Author

@Stevenic @tomlm Can you take a look at this PR if it's good on the protocol side?

Stevenic
Stevenic approved these changes Aug 13, 2018
View reviewed changes
Copy link

@Stevenic Stevenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@compulim compulim merged commit 3c666fd into microsoft:master Aug 14, 2018
@compulim compulim deleted the feat-role branch August 14, 2018 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stevenic Stevenic Stevenic approved these changes

@billba billba Awaiting requested review from billba

@sgellock sgellock Awaiting requested review from sgellock

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@compulim @Stevenic