Fix suggested-action regression where title does not get added to pos…

…tback and imback action buttons
microsoft · Jan 18, 2019 · 919501c · 919501c
1 parent 7a5cc3a
commit 919501c
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/...how-correctly-formatted-buttons-when-suggested-actions-are-displayed-1-snap.png b/...how-correctly-formatted-buttons-when-suggested-actions-are-displayed-1-snap.png
diff --git a/__tests__/suggestedActions.js b/__tests__/suggestedActions.js
@@ -9,6 +9,20 @@ function sleep(ms = 1000) {
 // https://seleniumhq.github.io/selenium/docs/api/javascript/module/selenium-webdriver/index_exports_WebDriver.html
 
 describe('suggested-actions command', async () => {
+    test('should show correctly formatted buttons when suggested actions are displayed', async() => {
+        const { driver } = await setupWebDriver();
+
+        await sleep(2000);
+
+        const input = await driver.findElement(By.tagName('input[type="text"]'));
+
+        await input.sendKeys('suggested-actions', Key.RETURN);
+        await sleep(2000);
+
+        const base64PNG = await driver.takeScreenshot();
+
+        expect(base64PNG).toMatchImageSnapshot(imageSnapshotOptions);
+    }, 60000);
 
     test('should show response from bot and no text from user on imback', async () => {
         const { driver } = await setupWebDriver();

diff --git a/packages/component/src/SendBox/SuggestedActions.js b/packages/component/src/SendBox/SuggestedActions.js
@@ -48,8 +48,11 @@ export default connectSuggestedActions(
             buttonText={
               type === 'messageBack' ?
                 title || displayText
-              :
-                title || (typeof value !== 'string') ? JSON.stringify(value) : value
+              : title ?
+                  title
+                : (typeof value === 'string') ?
+                  value
+                  : JSON.stringify(value)
             }
             displayText={ displayText }
             key={ index }