Skip to content

Commit

Permalink
Fixed Adaptive Cards not speaking (#2320)
Browse files Browse the repository at this point in the history
* Fixed Adaptive Cards not speaking

* Updated CHANGELOG.md
  • Loading branch information
tdurnford authored and corinagum committed Aug 15, 2019
1 parent 892e56e commit eaa1d22
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fix [#2273](https://github.com/microsoft/BotFramework-WebChat/issues/2273). Add `ScreenReaderText` component, by [@corinagum](https://github.com/corinagum) in PR [#2278](https://github.com/microsoft/BotFramework-WebChat/pull/2278)
- Fix [#2231](https://github.com/microsoft/BotFramework-WebChat/issues/2231). Fallback to English (US) if date time formatting failed, by [@compulim](https://github.com/compulim) in PR [#2286](https://github.com/microsoft/BotFramework-WebChat/pull/2286)
- Fix [#2298](https://github.com/microsoft/BotFramework-WebChat/issues/2298). Speech synthesize errors to be ignored, by [@compulim](https://github.com/compulim) in PR [#2300](https://github.com/microsoft/BotFramework-WebChat/issues/2300)
- Fix [#2243](https://github.com/microsoft/BotFramework-WebChat/issues/2243). Fixed sagas to correctly mark activities with speaking attachments, by [@tdurnford](https://github.com/tdurnford) in PR [#2320](https://github.com/microsoft/BotFramework-WebChat/issues/2320)

### Added

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,12 @@ function* speakActivityAndStartDictateOnIncomingActivityFromOthers({ userID }) {
const shouldSpeakIncomingActivity = yield select(shouldSpeakIncomingActivitySelector);
const shouldSpeak = speakableActivity(activity) && shouldSpeakIncomingActivity;

if (shouldSpeak && (activity.speak || activity.text)) {
if (
shouldSpeak &&
(activity.speak ||
activity.text ||
~(activity.attachments || []).findIndex(({ content: { speak } = {} }) => speak))
) {
yield put(markActivity(activity, 'speak', true));
}

Expand Down

0 comments on commit eaa1d22

Please sign in to comment.