Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Screen Reader - Identity Diagnostics - Virtual Assistant (Preview)] Screen reader doesn't announce updated message information which is provided by 'Virtual assistant'. #3484

Closed
PriyaSrivastava123 opened this issue Sep 16, 2020 · 4 comments
Assignees
Labels
area-accessibility Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. Duplicate This issue or pull request already exists p0 Must Fix. Release-blocker
Milestone

Comments

@PriyaSrivastava123
Copy link

PriyaSrivastava123 commented Sep 16, 2020

User Experience:
Properly defined information & relationship of an UI element helps people with different disabilities by allowing user agents to provide proper navigation & content according to the needs of individual users.

Note: User credentials should NOT be included in the bug.

Repro Steps:​

  1. Launch the URL: https://aka.ms/dxp-ux and login with credentials.
  2. Navigate to the Enterprise applications and select it.
  3. Navigate to the "Diagnose and solve problems
    " and select .
  4. Navigate to the various controls of the "Virtual assistant (Preview)
    " Blade .
  5. Verify that Screen reader announces updated message information which is provided by 'Virtual assistant' or not.

Actual Result:
Screen reader doesn't announce updated message information which is provided by 'Virtual assistant' that is 'Sorry, I didn't get that. Did you mean:....' after providing question by user.

Expected Result:
Screen reader should announce updated message information which is provided by 'Virtual assistant' that is 'Sorry, I didn't get that. Did you mean:....' after providing question by user.

Note:
Same issue exists on Firefox + NVDA & Chrome + JAWS.

MAS Reference:
MAS 1.3.1 Info and Relationship

Screen reader doesn't announce updated message information which provided by 'Virtual assistant'

@tsuwandy tsuwandy added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Required for internal Azure reporting. Do not delete. needs-triage labels Sep 16, 2020
@corinagum
Copy link
Contributor

I verified that this is running 4.10.0 Web Chat.
image
Testing on Chrome 85.0.4 with NVDA

Here is the log from NVDA:
image

To note, the announcement flow is interrupted by a URL (not sure of the source yet), which is not good UX. But even after waiting for that to be spoken, the announcement for the Adaptive Card is "Bot VA said: 1 attachment". It should definitely be speaking the contents of the card.

I have reproduced this issue on the Virtual Assistant, and am now investigating whether or not I can reproduce it in a separate bot. I will report back here.

@corinagum corinagum added the customer-replied-to Required for internal reporting. Do not delete. label Sep 16, 2020
@corinagum corinagum added the needs-repro Waiting for repro or investigation label Sep 16, 2020
@corinagum
Copy link
Contributor

corinagum commented Sep 18, 2020

I'm have confirmed this bug on Mock Bot in the browser as well. Looks like we have two a11y issues that need to be resolved: #3489

@corinagum corinagum added this to the Needs-scheduling milestone Sep 18, 2020
@corinagum corinagum added area-accessibility and removed needs-repro Waiting for repro or investigation labels Sep 18, 2020
@corinagum corinagum modified the milestones: Needs-scheduling, R11 Sep 18, 2020
@corinagum corinagum added bug Indicates an unexpected problem or an unintended behavior. and removed R11 labels Sep 29, 2020
@cwhitten cwhitten added the p0 Must Fix. Release-blocker label Oct 14, 2020
@corinagum
Copy link
Contributor

corinagum commented Oct 19, 2020

TLDR: I am closing this bug as "by design / won't fix" see comment below

  • I am no longer reproducing the long url that is read, which interrupted the speech flow of AT

After taking a look at the source code, I believe not reading the attachment is intentional behavior. The current ideal workflow is thus:

image

'Bot said, where are you located? 1 attachment'
(Focus remains on last clicked button)
(User presses tab)
Bot said, Where are you located? activity attachment (* This is the context being read)
USA button
(User presses tab)
Bot said, Where are you located? activity attachment
Other button

ScreenReaderActivity.js:
image

The intent here is that the context of the attachment (associated activity) will be read again when focus 'enters' the attachment.

@compulim Could I get a sanity check?
For related code changes, see #3287 (<ScreenReaderActivity.js>) and work item #3236

@corinagum
Copy link
Contributor

Oops. It looks like this is a dupe of #3521.

To recap: This behavior is intended but we want to update it in the feature-request linked above. Sorry for the confusion, folks. I'll keep this one closed in favor of the other, since that issue has a little more context.

@corinagum corinagum added the Duplicate This issue or pull request already exists label Oct 19, 2020
@microsoft microsoft locked and limited conversation to collaborators Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-accessibility Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. Duplicate This issue or pull request already exists p0 Must Fix. Release-blocker
Projects
None yet
Development

No branches or pull requests

4 participants