-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix post-4.9.1 accessibility issues #3287
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
requested review from
a-b-r-o-w-n,
beyackle,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
July 1, 2020 23:29
tdurnford
reviewed
Jul 2, 2020
tdurnford
reviewed
Jul 2, 2020
tdurnford
reviewed
Jul 2, 2020
tdurnford
reviewed
Jul 2, 2020
corinagum
reviewed
Jul 2, 2020
packages/bundle/src/adaptiveCards/Attachment/AdaptiveCardRenderer.js
Outdated
Show resolved
Hide resolved
tdurnford
reviewed
Jul 2, 2020
corinagum
reviewed
Jul 2, 2020
corinagum
reviewed
Jul 2, 2020
corinagum
approved these changes
Jul 2, 2020
@corinagum Setting a Try this one, https://codepen.io/compulim/pen/xxZpXEX. |
Co-authored-by: TJ Durnford <[email protected]> Co-authored-by: Corina <[email protected]>
This was referenced Jul 8, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
<ScreenReaderActivity>
component<CarouselFilmstrip>
,<StackedLayout>
,<TextContent>
, and<Timestamp>
replyToId
that reference an activity which is not ACK-ed, for up to 5 secondstabindex="-1"
set, instead ofdisabled
attributetabindex="-1"
from Adaptive Cards containerinvoke
Description
Few areas of improvements:
replyToId
property as a hinttabindex="-1"
for disabling button and prevent it from accessible through TAB keytabindex="-1"
on the<div>
, which is the Adaptive Card containerFor details, please refer to specific changes section.
Specific Changes
replyToId
referencing an activity that is not received yet, the delay is up to 5 seconds (non-configurable)replyToId
reference, are not affectedtabIndex
set to-1
to prevent it from being focused on via the TAB keyonblur
event handler will adddisabled
attribute to the element to disable the TAB keytabindex="-1"
to Adaptive Card container, which would cause them to be focusable on mouse clickpreview-branch.yml
preview-*
is pushed tomicrosoft/BotFramework-WebChat
fork, it will create a new release (tarball + bundle)master
)