-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QFE for 4.5.3 #2454
Closed
QFE for 4.5.3 #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * Fix README sample link * Update Legacy lifecycle methods to UNSAFE_ * fix #2193: Attachments not spoken by Narrator * Add timestamp back to aria-labels * fixes * PR fixes * Apply PR fixes
* Add array.flat from core-js * Add object.keys from core-js
* 4.5.1 * 4.5.1
* Create component ScreenReaderText * Update CHANGELOG.md * PR cleanup * PR cleanup
* Fix aria-label of Sendbox * Edit CHANGELOG.md * Add localization * Update CHANGELOG.md Co-Authored-By: TJ Durnford <[email protected]> * Update CHANGELOG.md Co-Authored-By: TJ Durnford <[email protected]>
* Add downscale on upload * Clean up * Add entry * Separate worker into another file * Check for downscale support * Add comment * Add style options for thumbnail * Typo * Add test * Rename styleOptions for upload thumbnail * Fix ESLint * Add upload text file * Cleanup * Update entry * Update entry * Fix broken propTypes * More robust capability check * Fix tests * Fix tests * Add snapshot * Apply suggestions from code review Co-Authored-By: Corina <[email protected]> * Incorporate PR comments * Thumbnail support for Edge, Firefox, and IE11 * Fix ESLint * Fix promise chaining * Fix test
…ls (#2262) * Add upload attachment renderer * Check thumbnail * Update PR number * Fix propTypes * Fix render error for text attachment * Update non-photo upload PNGs
* Use thumbnail URL * Update PR number * Update CHANGELOG.md Co-Authored-By: TJ Durnford <[email protected]> * Fix ESLint * Fix ESLint * Fix ESLint
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
tdurnford and
tonyanziano
as code owners
October 6, 2019 21:44
Wrong branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Changed
bundle
: Bumped DirectLineJS to support metadata when uploading attachments, in PR #2433[email protected]
component
because it was not referencedFixed
attachment.thumbnailUrl
field, by @compulim in PR #2433Added
channelData.attachmentThumbnails
, by @compulim, in PR #2206, requires modern browsers with following features:createImageBitmap
MessageChannel
/MessagePort
OffscreenCanvas
OffscreenCanvas.getContext('2d')
activity.attachments[].thumbnailUrl
, by @compulim in PR #2433Description
thumbnailUrl
for thumbnails #2433Specific Changes
Testing Added