Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use markdown-it-attrs-es5 bridge #3025

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Mar 17, 2020

Fixes #3024.

Changelog Entry

Fixed

Description

markdown-it-attrs introduced in #3022 is not compatible with IE11. We need to add a bridging package markdown-it-attrs-es5 which transpile it on-install.

It is normal that a lot of changes in package.json because dev: true is removed. Although the package include babel-loader as dev dependencies, it's transient dependencies of a prod dependency. Thus, all dev dependencies starting from babel-loader and down the tree will have their dev: true removed.

In other words, dev: true is only for "truly/fully dev dependencies".

Specific Changes


  • Testing Added
    • Existing manual test will cover this case

@corinagum corinagum merged commit db9ef47 into microsoft:master Mar 17, 2020
@compulim compulim mentioned this pull request May 15, 2020
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IE11] Fix ES5 build for markdown-it-attrs
3 participants