Use <ScreenReaderText> in favor of aria-label #3097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
compulim
changed the title
corinagum
approved these changes
Apr 10, 2020
compulim
added a commit
that referenced
this pull request
Apr 10, 2020
Co-authored-by: Corina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixes
<ScreenReaderText>instead ofaria-labelfor message bubbles, by @compulim in PR #3097Description
aria-labelis not very reliable. We should use<ScreenReaderText>instead.Since we are in a hurry for this PR, we are only changing high-impact areas, i.e. message bubbles only.
Specific Changes
<ScreenReaderText>aria-hidden="true"to<div>that are purely cosmetics (e.g. filler)<Bubble>should defaultaria-hiddentoundefined(unset) to match HTML default behaviorTesting Added