Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "noopener noreferrer" to card action #3224

Merged
merged 2 commits into from
Jun 9, 2020

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Jun 8, 2020

Fixes #3223.

Changelog Entry

Fixed

  • Fixed #3223. Tap an openUrl card action should open URL in a new tab with noopener noreferrer set, by @compulim in PR #3224

Description

Add noopener noreferrer to openUrl card action. This card action is used by Adaptive Card, hero card, suggested actions, etc.

Specific Changes

  • Modify the default card action middleware
    • When a card action of openUrl is being executed, it should open using window.open(url, '_blank', 'noopener noreferrer')

  • Testing Added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Card action should open in new window with "noopener" and "noreferrer"
2 participants