Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRST] Bump dependencies after release of 4.14.0 #3996

Merged
merged 28 commits into from
Aug 11, 2021

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Jul 20, 2021

Fixes #3715. Fixes #3995.

Changelog Entry

Description

Tested on IE11.

Please see specific changes.

What's left after this PR:

  • We still need to fork/bump cldr-data-downloader in another PR
  • Look at other reports
  • Bump Docker images for Chromium (lower priority)

Design

Specific Changes

  • Prettier changed some rules, need to reformat some code
  • Upgraded signature of event-target-shim
  • Moved from jsonwebtoken.decode() to jwt-decode
    • jsonwebtoken requires node:buffer, node:crypto, node:stream. But jwt-decode only target browser and no requirement on Web Crypto
    • We did not use jsonwebtoken.verify() to verify the integrity of the token. And the newer jwt-decode do not offer verification, which is okay for us
  • Updated peer dependencies of React to >= 16.8.6 which includes 17
    • Starting from npm@7, unfulfilled peer dependencies will be automatically installed
    • That means, web devs who use react other than 16.8.6, will have 2 versions of React installed
    • We should update the peer dependencies so only 1 version of React is installed

Test snapshot change

video-js-video-1-diff

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review July 20, 2021 12:05
@compulim compulim changed the title Bump dependencies after release of 4.14.0 [FIRST] Bump dependencies after release of 4.14.0 Jul 30, 2021
@compulim compulim merged commit 7374dba into microsoft:main Aug 11, 2021
@compulim compulim deleted the bump-4.14.1-0 branch August 11, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants