useSubmit() should function after reconnect #4707
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
Description
When DLASE reconnect,
ConnectionStatus.Connecting
andConnectionStatus.Online
is observed again. This triggeredDIRECT_LINE/RECONNECT_*
actions.After reconnected, the
useConnectivityStatus()
hook returns["reconnected"]
, instead of["connected"]
.However, in our
useSubmit()
hook, we only cater"connected"
but not"reconnected"
. That means, reconnected is more-or-less same as disconnected.That means, when clicking on send button or ENTER key, it is not functional because
useSubmit()
think it is offline.We checked other source code, and no other similar issues were discovered.
Although
useSubmit()
disable text box submission when offline, other hooks (e.g.useSendPostBack
,useSendEvent
, etc.) does not look at online status.We should revisit the whole scenario again:
Specific Changes
useSubmit()
to consider both"connected"
and"reconnected"
cases as connectedCHANGELOG.md
Review Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)