Audit in programmability sample #6258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyashton
reviewed
Jun 12, 2024
8 tasks
eddyashton
approved these changes
Jun 14, 2024
…achamayou/CCF into audit_in_programmability_sample
sidmore
reviewed
Jun 17, 2024
| @@ -223,10 +228,19 @@ namespace programmabilityapp | |||
| } | |||
| // End of Authorization Check | |||
|
|
|||
| const auto bundle = get_body(ctx); | |||
| const auto [format, bundle] = get_body(ctx); | |||
There was a problem hiding this comment.
what is format and bundle here?
There was a problem hiding this comment.
See definition of get_body() on line 52, format is an enum (AuditInputFormat) and bundle is a std::span (i.e. the actual body, which could be either JSON or COSE, as indicated by format).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the following endpoints:
PUT /app/custom_endpointsPATCH /app/custom_endpoints/runtime_optionInput payloads (i.e. request bodies) are logged to
public:custom_endpoints.audit.input, and metadata is logged atpublic:custom_endpoints.audit.info, with the following fields:formatone ofCOSE,JSON.contentone ofBUNDLE,OPTIONS.user_idthe user id of the caller.Note that only
COSEpayloads are offline verifiable, i.e. can be checked by an outside auditor without having to trust the service, since they are signed directly by the user key. For payloads that come in via client certificate authentication, the content and user id are recorded by the service, which is trusted to do this accurately.