Change offset commit behaviour to be in line with Java consumers

[ducas]

… versus previously consumed offset. Fixes #27

[mhorstma]

What would be the risk of making this the default behavior, since it seems that this is a more correct way of managing committed offsets? The expansion of various little config settings is starting to get a little crazy.

[ducas]

i agree that a config setting for everything can get crazy. i would like to
see parity with the java consumer configuration though...

i can run a few tests to see if you get duplicate messages or not. the only
other problem i can think of is that it will affect monitoring tools -
which is the reason i would like to fix it... :-)

On Thu, Apr 7, 2016 at 3:10 AM mhorstma [email protected] wrote:

What would be the risk of making this the default behavior, since it seems
that this is a more correct way of managing committed offsets? The
expansion of various little config settings is starting to get a little
crazy.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#45 (comment)

Cheers,
Ducas

[mhorstma]

Your point of keeping parity with the Java consumer config is a good one. I think this change looks good.

[ducas]

@mhorstma how does this look now...?

[mhorstma]

Looks great to me. Let's give others a little time to weigh in, if they wish, before merging.

[ducas]

i've rejigged and rebased this PR as #46 caused conflicts